refactor(test): playwrightテストの共通部分を少しリファクタリング、歌詞編集テストの移動 - #2562
Merged
Hiroshiba merged 1 commit intoMar 1, 2025
Hidden character warning
The head ref may contain hidden characters: "refactor(test)--playwright\u30c6\u30b9\u30c8\u306e\u5171\u901a\u90e8\u5206\u3092\u5c11\u3057\u30ea\u30d5\u30a1\u30af\u30bf\u30ea\u30f3\u30b0\u3001\u6b4c\u8a5e\u7de8\u96c6\u30c6\u30b9\u30c8\u306e\u79fb\u52d5"
Merged
Conversation
Hiroshiba
commented
Feb 25, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/e2e/navigators.ts:63
- [nitpick] For consistency with other navigation functions that specify a return type (e.g. navigateToHelpDialog and navigateToSettingDialog), consider adding an explicit return type annotation to navigateToSong.
export async function navigateToSong(page: Page) {
Hiroshiba
commented
Feb 25, 2025
Comment on lines
+69
to
+71
| // 見やすいようにスナップを1/8に変更 | ||
| await page.getByLabel("スナップ").click(); | ||
| await page.getByRole("option", { name: "1/8", exact: true }).click(); |
Member
Author
There was a problem hiding this comment.
あ、これはちょっとテストのやりやすさのために追加しました。
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Hiroshiba
commented
Mar 1, 2025
Member
Author
There was a problem hiding this comment.
このテストの変更は完全にtests/e2e/browser/song/歌詞.spec.tsに移動しただけです
Member
Author
|
@sevenc-nanashi 共通部分のリファクタリングとして、 |
Member
Author
|
ありがとうございます！ マージします！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
playwrightテストの共通部分をtest.stepにし、テスト結果を少しわかりやすくします。
関連 Issue
から派生
スクリーンショット・動画など
stepにしておくとこんな感じでまとめてくれる（右の「ソング画面に移動」みたいに）ので、どのタイミングで落ちたのかわかりやすくなるから多用していきたい気持ち。
その他