feat: 音声のスケジューリングでずれが発生しないようにする - #2594
Merged
Hiroshiba merged 1 commit intoMar 7, 2025
Merged
Conversation
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Contributor
There was a problem hiding this comment.
PR Overview
This PR implements a fix to prevent timing discrepancies in audio scheduling. Key changes include:
- Adding a helper function to determine the earliest schedulable context time.
- Introducing a new private audioContext field in the AudioPlayerVoice class.
- Adjusting the scheduling logic in AudioPlayerVoice.start to compensate for potential delays.
Reviewed Changes
| File | Description |
|---|---|
| src/sing/audioRendering.ts | Added a helper function and modified AudioPlayerVoice to adjust schedule |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/sing/audioRendering.ts:554
- Ensure that the variable 'offset' is properly defined and validated prior to being modified within the adjustment block to avoid potential runtime errors.
const earliestSchedulableContextTime = getEarliestSchedulableContextTime(
Hiroshiba
approved these changes
Mar 7, 2025
Hiroshiba
left a comment
Hiroshiba
left a comment
Member
There was a problem hiding this comment.
LGTM！！
ロジックがこれで問題ないのかは実はちょっとわかってませんが、動かしてみた感じ特に問題は見つからなかったので良さそう！！
Hiroshiba
enabled auto-merge
March 7, 2025 04:58
sevenc-nanashi
pushed a commit
to sevenc-nanashi/voicevox
that referenced
this pull request
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
音声のスケジューリングでずれが発生しないようにします。
（ #2215 (comment) の2番目の方法で実装します）
関連 Issue
その他