fix!: bpmInputBufferをなくしつつ、再生中でもbpmを変更できるようにする - #2603
Merged
Conversation
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Contributor
There was a problem hiding this comment.
PR Overview
This PR addresses issue #2593 by removing the redundant bpmInputBuffer and enabling bpm updates during playback.
- Removes bpmInputBuffer and associated update logic
- Updates QInput bindings and event handlers to directly use the computed bpm value
Reviewed Changes
| File | Description |
|---|---|
| src/components/Sing/ToolBar/ToolBar.vue | Refactors bpm handling by replacing bpmInputBuffer with a computed property and renaming the associated update function |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Hiroshiba
commented
Mar 9, 2025
sigprogramming
approved these changes
Mar 10, 2025
sigprogramming
left a comment
sigprogramming
left a comment
Collaborator
There was a problem hiding this comment.
LGTM！
修正ありがとうございます！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
の解決案です。
関連 Issue
close #2593
その他