Skip to content

fix(ci): モックエンジンをwarm upしてテストが時間切れになるのを防ぐ - #2730

Merged
sevenc-nanashi merged 4 commits into
mainfrom
codex/create-pr-to-resolve-issue-2729
Sep 6, 2025
Merged

fix(ci): モックエンジンをwarm upしてテストが時間切れになるのを防ぐ#2730
sevenc-nanashi merged 4 commits into
mainfrom
codex/create-pr-to-resolve-issue-2729

Conversation

@Hiroshiba

@Hiroshiba Hiroshiba commented Sep 6, 2025

Copy link
Copy Markdown
Member

内容

モックエンジンをwarm upしてテストが時間切れになるのを防ぐようにしてみました。

関連 Issue

スクリーンショット・動画など

  • N/A

その他

個人的なメモ

CodexのURL
https://chatgpt.com/codex/tasks/task_e_68bc2424f770832890ff05eeeb529d33

@Hiroshiba
Hiroshiba requested a review from a team as a code owner September 6, 2025 13:32
@Hiroshiba Hiroshiba changed the title fix: warm up engine mock tokenizer [update snapshots] (#2729) fix(ci): モックエンジンをwarm upしてテストが時間切れになるのを防ぐ Sep 6, 2025
@Hiroshiba
Hiroshiba requested a review from Copilot September 6, 2025 13:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses test timeout issues by pre-warming the mock engine. The changes add a beforeAll hook to warm up the tokenizer before running tests, preventing timeouts during test execution.

  • Pre-warm the tokenizer in test setup to avoid timeouts
  • Export the createOrGetTokenizer function to make it accessible for warm-up

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/unit/mock/engineMock/index.spec.ts Adds beforeAll hook to warm up tokenizer before tests run
src/mock/engineMock/talkModelMock.ts Exports createOrGetTokenizer function for external access

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Hiroshiba

Copy link
Copy Markdown
Member Author

@codex レビューお願いします

@voicevox-preview-pages

voicevox-preview-pages Bot commented Sep 6, 2025

Copy link
Copy Markdown

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:ecc38a5

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@Hiroshiba

Hiroshiba commented Sep 6, 2025

Copy link
Copy Markdown
Member Author

@copilot
tests/e2e/storybook/スクリーンショット.spec.ts-snapshots/components-sing-changevaluedialog-timesignaturechangedialog--change-opened-light-storybook-win32.png
tests/e2e/storybook/スクリーンショット.spec.ts-snapshots/components-dialog-saveallresultdialog--single-error-light-storybook-win32.png
が無駄に変更されてしまっているので、これらをmainブランチのものにgit checkoutしてください。

@sevenc-nanashi sevenc-nanashi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう。

@sevenc-nanashi

Copy link
Copy Markdown
Member

マージします。

@sevenc-nanashi
sevenc-nanashi added this pull request to the merge queue Sep 6, 2025
Merged via the queue into main with commit 1024fdd Sep 6, 2025
19 checks passed
@Hiroshiba
Hiroshiba deleted the codex/create-pr-to-resolve-issue-2729 branch September 6, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

engineMockのテストがスナップショット不一致とタイムアウトで失敗する

4 participants