Skip to content

build: {ja,en-US}.pakロケール以外の言語パックを削除する - #2752

Merged
sevenc-nanashi merged 1 commit into
VOICEVOX:mainfrom
oech3:locale-keep
Sep 27, 2025
Merged

build: {ja,en-US}.pakロケール以外の言語パックを削除する#2752
sevenc-nanashi merged 1 commit into
VOICEVOX:mainfrom
oech3:locale-keep

Conversation

@oech3

@oech3 oech3 commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

内容

electronLanguagesで不要なロケールを消す。
macOSには何故か聞かない。#2751 を置き換える。

関連 Issue

close #2748

@voicevox-preview-pages

Copy link
Copy Markdown

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:d6fbe29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unnecessary locale files from Electron builds by specifying only Japanese and English (US) locales to reduce bundle size. The change addresses issue #2748 by adding an electronLanguages configuration to the Electron Builder settings.

  • Adds electronLanguages configuration to limit included locales to ["en-US", "ja"]

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Hiroshiba Hiroshiba changed the title {ja,en-US}.pakロケールだけ残す build: {ja,en-US}.pakロケール以外の言語パックを削除する Sep 26, 2025

@sevenc-nanashi sevenc-nanashi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

特に問題なさそう。一応 @sabonerune さん待ち。

@sabonerune sabonerune left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

恐らく問題ないと思います。
macOSで削除されない問題はどうやらelectron-builder v26.0.15で修正されると思います。

@sevenc-nanashi

Copy link
Copy Markdown
Member

問題なさそうなのでマージします。ありがとうございました。

@sevenc-nanashi
sevenc-nanashi added this pull request to the merge queue Sep 27, 2025
Merged via the queue into VOICEVOX:main with commit 50d5379 Sep 27, 2025
11 checks passed
@oech3
oech3 deleted the locale-keep branch September 27, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

不要な*.pakを消して42 MBほど節約する

4 participants