build: {ja,en-US}.pakロケール以外の言語パックを削除する - #2752
Merged
Merged
Conversation
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary locale files from Electron builds by specifying only Japanese and English (US) locales to reduce bundle size. The change addresses issue #2748 by adding an electronLanguages configuration to the Electron Builder settings.
- Adds
electronLanguagesconfiguration to limit included locales to["en-US", "ja"]
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sevenc-nanashi
approved these changes
Sep 26, 2025
sabonerune
approved these changes
Sep 26, 2025
Contributor
There was a problem hiding this comment.
恐らく問題ないと思います。
macOSで削除されない問題はどうやらelectron-builder v26.0.15で修正されると思います。
Member
|
問題なさそうなのでマージします。ありがとうございました。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
electronLanguagesで不要なロケールを消す。
macOSには何故か聞かない。#2751 を置き換える。
関連 Issue
close #2748