Repository navigation
Spark: Implement ArrayData.getVariant for row-based Parquet readers - #14349
Merged
Merged
Conversation
Contributor
Author
singhpk234
reviewed
Oct 27, 2025
| @ValueSource(booleans = {false, true}) | ||
| public void testNestedStructVariant(boolean vectorized) { | ||
| assumeThat(vectorized).as("Variant vectorized Parquet read is not implemented yet").isFalse(); | ||
| spark.conf().set("spark.sql.parquet.enableVectorizedReader", String.valueOf(vectorized)); |
Contributor
There was a problem hiding this comment.
nit : we have withSQLConf in iceberg too, can try using it ?
Contributor
Author
There was a problem hiding this comment.
I just noticed that some of the tests in this test set vectorization via table property. To be consistent, I will change all the tests to use table property.
aihuaxu
reviewed
Oct 31, 2025
singhpk234
approved these changes
Nov 5, 2025
singhpk234
left a comment
singhpk234
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @huaxingao !
Contributor
Author
|
Thanks @aihuaxu @singhpk234 for the review! |
thomaschow
pushed a commit
to thomaschow/iceberg
that referenced
this pull request
Jan 19, 2026
…pache#14349) * Spark: Implement ArrayData.getVariant for row-based Parquet readers * address comments * address comments * fix set vectorization
talatuyarer
pushed a commit
to talatuyarer/iceberg
that referenced
this pull request
Apr 1, 2026
…pache#14349) * Spark: Implement ArrayData.getVariant for row-based Parquet readers * address comments * address comments * fix set vectorization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.