Repository navigation
Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains - #14497
Merged
Conversation
manuzhang
approved these changes
Nov 4, 2025
singhpk234
reviewed
Nov 4, 2025
| } | ||
|
|
||
| private static ParserInterface getNextDelegateParser(ParserInterface parser) { | ||
| Logger logger = LoggerFactory.getLogger(ExtendedParser.class); |
Contributor
There was a problem hiding this comment.
can we not declare this as private static final member of the interface
Contributor
Author
There was a problem hiding this comment.
Interface fields cannot be private in Java.
Can the code be written like this?
public interface ExtendedParser extends ParserInterface {
Logger LOG = LoggerFactory.getLogger(ExtendedParser.class);
…er in parser chains
…endedParser in parser chains
…endedParser in parser chains
…endedParser in parser chains
…endedParser in parser chains
…endedParser in parser chains
…endedParser in parser chains
majian1998
force-pushed
the
fix-parser-fu-4
branch
from
November 4, 2025 06:18
0925665 to
4c3fd36
Compare
…endedParser in parser chains
ebyhr
reviewed
Nov 4, 2025
…endedParser in parser chains
nastra
reviewed
Nov 4, 2025
| } | ||
|
|
||
| current = next; | ||
| current = getNextDelegateParser(current); |
Contributor
There was a problem hiding this comment.
is this fixing an actual issue? It would be good to have a test for this
Contributor
Author
There was a problem hiding this comment.
This just simplifies the code. The logic stays the same. It’s a follow-up PR, and the original tests already cover this.
huaxingao
reviewed
Nov 5, 2025
…endedParser in parser chains
huaxingao
approved these changes
Nov 5, 2025
Contributor
|
Thanks @majian1998 for the PR! Thanks everyone for the review! |
thomaschow
pushed a commit
to thomaschow/iceberg
that referenced
this pull request
Jan 19, 2026
…endedParser in parser chains (apache#14497) * Follow-up: Support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains
talatuyarer
pushed a commit
to talatuyarer/iceberg
that referenced
this pull request
Apr 1, 2026
…endedParser in parser chains (apache#14497) * Follow-up: Support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains * Follow-up: Optimize support recursive delegate unwrapping to find ExtendedParser in parser chains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: #13625, #14483
Some follow-up code optimizations. Thanks to @kamcheungting-db for the suggestions.