Skip to content

Core: Fix RESTCatalogAdapter for Remote Scan Planning - #14629

Merged
amogh-jahagirdar merged 3 commits into
apache:mainfrom
singhpk234:fix/catalog-adapter
Nov 20, 2025
Merged

Core: Fix RESTCatalogAdapter for Remote Scan Planning#14629
amogh-jahagirdar merged 3 commits into
apache:mainfrom
singhpk234:fix/catalog-adapter

Conversation

@singhpk234

@singhpk234 singhpk234 commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

About the change

  1. Adds "sync" and "async" prefix to the plan-id to help in debugging
  2. According to REST spec in the plan API call when we return the COMPLETED status its required to return plan-id to the client as the client needs it for subsequent call (for example cancel API)

    iceberg/open-api/rest-catalog-open-api.yaml

    Line 3454 in 4ee507d

    completed: '#/components/schemas/CompletedPlanningWithIDResult'

    we should mark plan-id as required orthogonally though
  3. Fixes a race condition where a client might come back to the server even when the server is still populating the IN_MEMORY_PLANNING_STATE in a seperate thread what this would mean is it can fail when the fetch plan task is called and nothing is populated hence resulting in Plan-id not found Exception.

co-author : @amogh-jahagirdar

Testing

present in #13400

@github-actions github-actions Bot added the core label Nov 19, 2025
@nastra nastra changed the title REST: Fix RESTCatalogAdapter for Remote Scan Planning Core: Fix RESTCatalogAdapter for Remote Scan Planning Nov 19, 2025
nastra
nastra reviewed Nov 19, 2025
View reviewed changes
Comment thread core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java Outdated
@singhpk234 singhpk234 mentioned this pull request Nov 19, 2025
Merged
huaxingao
huaxingao approved these changes Nov 20, 2025
View reviewed changes

@huaxingao huaxingao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amogh-jahagirdar

amogh-jahagirdar commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

Awesome, thanks for this @singhpk234 and @nastra @huaxingao for reviewing. I'll go ahead and merge to unblock rebasing the client integration PR, @nastra if there's any further coments we can address them in that PR.

@amogh-jahagirdar
amogh-jahagirdar merged commit 0d4d3a5 into apache:main Nov 20, 2025
44 checks passed
thomaschow pushed a commit to thomaschow/iceberg that referenced this pull request Jan 19, 2026
@singhpk234 @sfc-gh-prsingh
@amogh-jahagirdar @thomaschow
Core: Fix Async Planning handling in RESTCatalogAdapter for Remote Sc…
8786075 
…an Planning (apache#14629)

Co-authored-by: Prashant Singh <prashant.singh@snowflake.com>
Co-authored-by: Amogh Jahagirdar <amoghj@apache.org>
talatuyarer pushed a commit to talatuyarer/iceberg that referenced this pull request Apr 1, 2026
@singhpk234 @sfc-gh-prsingh
@amogh-jahagirdar @talatuyarer
Core: Fix Async Planning handling in RESTCatalogAdapter for Remote Sc…
c603862 
…an Planning (apache#14629)

Co-authored-by: Prashant Singh <prashant.singh@snowflake.com>
Co-authored-by: Amogh Jahagirdar <amoghj@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nastra nastra nastra left review comments
@huaxingao huaxingao huaxingao approved these changes
@amogh-jahagirdar amogh-jahagirdar amogh-jahagirdar approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@singhpk234 @amogh-jahagirdar @nastra @huaxingao @sfc-gh-prsingh