Skip to content

Docs: fix rendering issues in encryption doc - #14756

Merged
huaxingao merged 1 commit into
apache:mainfrom
huaxingao:enc_doc
Dec 5, 2025
Merged

huaxingao merged 1 commit into
apache:mainfrom
huaxingao:enc_doc

Conversation

@huaxingao

Copy link
Copy Markdown
Contributor
Screenshot 2025-12-03 at 9 36 47 PM Screenshot 2025-12-03 at 9 37 06 PM Screenshot 2025-12-03 at 9 37 18 PM

@github-actions github-actions Bot added the docs label Dec 4, 2025
@huaxingao huaxingao mentioned this pull request Dec 4, 2025
@huaxingao

Copy link
Copy Markdown
Contributor Author

@ggershinsky

Copy link
Copy Markdown
Contributor

Thanks!

Comment thread docs/docs/encryption.md
number generator. For Parquet data files, these parameters are passed to the native Parquet Modular
Encryption [mechanism](https://parquet.apache.org/docs/file-format/data-pages/encryption). For Avro data files,
these parameters are passed to the AES GCM Stream encryption [mechanism](../../format/gcm-stream-spec.md).
these parameters are passed to the AES GCM Stream encryption [mechanism](../../gcm-stream-spec.md).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work ok in the main branch? These refs are broken in https://github.com/huaxingao/iceberg/blob/enc_doc/docs/docs/encryption.md

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it on my local, with format it has problems, without format it works OK

Screenshot 2025-12-03 at 11 14 15 PM

@ggershinsky ggershinsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huaxingao

@singhpk234 singhpk234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @huaxingao !

@huaxingao
huaxingao merged commit ba98347 into apache:main Dec 5, 2025
4 checks passed
@huaxingao

Copy link
Copy Markdown
Contributor Author

Thanks @ggershinsky @singhpk234 for the review!

thomaschow pushed a commit to thomaschow/iceberg that referenced this pull request Jan 19, 2026
talatuyarer pushed a commit to talatuyarer/iceberg that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants