Skip to content

Core: Invalidate ShreddedObject serialization cache on remove - #15097

Merged
RussellSpitzer merged 1 commit into
apache:mainfrom
huaxingao:shreddedObject_remove
Jan 26, 2026
Merged

RussellSpitzer merged 1 commit into
apache:mainfrom
huaxingao:shreddedObject_remove

Conversation

@huaxingao

Copy link
Copy Markdown
Contributor

ShreddedObject caches a SerializationState used by sizeInBytes and writeTo. remove mutates the object but didn’t clear the cache, so subsequent serialization could include removed fields. This PR invalidates the cache on remove

@github-actions github-actions Bot added the core label Jan 21, 2026

@aihuaxu aihuaxu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the issue.

@huaxingao

Copy link
Copy Markdown
Contributor Author

cc @singhpk234 @amogh-jahagirdar Could you please take a look when you have a moment?

@RussellSpitzer
RussellSpitzer merged commit 7bead8a into apache:main Jan 26, 2026
32 checks passed
@RussellSpitzer

Copy link
Copy Markdown
Member

Thanks @huaxingao for the PR, and @aihuaxu for the review!

@huaxingao
huaxingao deleted the shreddedObject_remove branch January 26, 2026 19:14
talatuyarer pushed a commit to talatuyarer/iceberg that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants