Repository navigation
Build: Support building site with uv - #15118
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for building the Iceberg documentation site using uv, a modern Python package installer and resolver. The change makes the pip command configurable via an environment variable while maintaining backward compatibility with the existing pip-based workflow.
Changes:
- Modified
site/dev/common.shto allow overriding the pip command via thePIPenvironment variable - Added
.python-versionto.gitignore(created by uv)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| site/dev/common.sh | Made the pip command configurable via PIP environment variable, defaulting to the existing venv pip3 path |
| .gitignore | Added .python-version file to ignore list for uv compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kevinjqliu
left a comment
There was a problem hiding this comment.
the current change only allows overriding PIP in common.sh
there are a lot of places in the .sh files using ${VENV_DIR}/bin/python3, i actually want to replaced all of those with uv
similar to #14684 which was for open-api
0af156c to
9a22bc2
Compare
Yes, it works for me to use uv as an alternative locally with |
|
we hardcode It might get confusing otherwise. For example, uv allows to create venv dir with different names, while the script is hardcoded to Line 22 in 7493a15 |
9a22bc2 to
46e92b2
Compare
|
@kevinjqliu |
kevinjqliu
left a comment
There was a problem hiding this comment.
thanks! i think the VENV_DIR change alone should allow using environment created by uv. wdyt?
imo to fully support "Build: Support building site with uv", we should change all the scripts currently using VENV_DIR/pip/pip3/python/python3 to uv commands
kevinjqliu
left a comment
There was a problem hiding this comment.
thanks for catching me up on this. it makes sense, and being able to override pip with uv pip resolves deps much faster.
do you mind adding some context in the pr description?
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the PR @manuzhang ! |
Currently, in the site build python script, both
VENV_DIRand pip command are hard-coded, which prevents us from usinguvto built site locally. To lift the limit, this PR exposesVENV_DIRandPIPas environment variables.Run with uv using