Skip to content

[1.9.x] Fix locking issues - #1662

Merged
cstamas merged 7 commits into
apache:maven-resolver-1.9.xfrom
cstamas:maven-resolver-1.9.x-locking-issues
Nov 17, 2025
Merged

[1.9.x] Fix locking issues#1662
cstamas merged 7 commits into
apache:maven-resolver-1.9.xfrom
cstamas:maven-resolver-1.9.x-locking-issues

Conversation

@cstamas

@cstamas cstamas commented Nov 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Changes:

  • introduce dedicated ex (backport from 2)
  • up default timeouts (from 30s to 900s)
  • improve message by listing all lock subjects
  • improve message by mentioning the property that user should use to increase timeouts (there is no one size fits all; we could go with "infinite" timeouts. but am unsure about that)

@cstamas cstamas changed the title Lock issues [1.9.x] Fix locking issues Nov 17, 2025
@cstamas cstamas added this to the 1.9.25 milestone Nov 17, 2025
gnodet
gnodet reviewed Nov 17, 2025
View reviewed changes
Comment thread ...rc/main/java/org/eclipse/aether/internal/impl/synccontext/named/NamedLockFactoryAdapter.java Outdated
if (!metadata.getGroupId().isEmpty()) {
name += metadata.getGroupId();
if (!metadata.getArtifactId().isEmpty()) {
name += "." + metadata.getArtifactId();

@gnodet gnodet Nov 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

. or : ?

@cstamas cstamas Nov 17, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@cstamas
cstamas marked this pull request as ready for review November 17, 2025 11:15
@cstamas cstamas added the bug Something isn't working label Nov 17, 2025
@cstamas
cstamas merged commit f181c06 into apache:maven-resolver-1.9.x Nov 17, 2025
17 checks passed
@cstamas
cstamas deleted the maven-resolver-1.9.x-locking-issues branch November 17, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnodet gnodet gnodet left review comments
@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees

@cstamas cstamas

Labels

bug Something isn't working

Projects

None yet

Milestone

1.9.25

Development

Successfully merging this pull request may close these issues.

3 participants

@cstamas @gnodet @slawekjaranowski