Skip to content

[fix][broker] Make ExtensibleLoadManagerImpl.getOwnedServiceUnits async - #22727

Merged
heesung-sohn merged 1 commit into
apache:masterfrom
heesung-sohn:getOwnedServiceUnits-async
May 17, 2024
Merged

heesung-sohn merged 1 commit into
apache:masterfrom
heesung-sohn:getOwnedServiceUnits-async

Conversation

@heesung-sohn

Copy link
Copy Markdown
Contributor

Motivation

Pulsar Metadata Store Callbacks shouldn't be a blocking call. Otherwise, this blocking call could block the Metadata executor thread.

Modifications

  • Make ExtensibleLoadManagerImpl.getOwnedServiceUnits async

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label May 17, 2024
@heesung-sohn heesung-sohn self-assigned this May 17, 2024
@Demogorgon314 Demogorgon314 reopened this May 17, 2024
@heesung-sohn
heesung-sohn merged commit fd5916c into apache:master May 17, 2024
@lhotari

lhotari commented May 17, 2024

Copy link
Copy Markdown
Member

@heesung-sn Please tag the target releases where this will be cherry-picked.

@heesung-sohn

Copy link
Copy Markdown
Contributor Author

I cherry-picked this to 3.0, 3.1, 3.2, and 3.3.

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 31, 2024
…nc (apache#22727)

(cherry picked from commit fd5916c)
(cherry picked from commit 05317c8)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2024
…nc (apache#22727)

(cherry picked from commit fd5916c)
(cherry picked from commit 18f4226)
mukesh154 pushed a commit to cognitree/ds_pulsar that referenced this pull request Jun 4, 2024
…nc (apache#22727)

(cherry picked from commit fd5916c)
(cherry picked from commit 05317c8)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 7, 2024
…nc (apache#22727)

(cherry picked from commit fd5916c)
(cherry picked from commit 18f4226)
@heesung-sohn heesung-sohn added this to the 3.3.0 milestone Jun 27, 2024
@lhotari lhotari modified the milestones: 3.3.0, 4.0.0 Oct 14, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants