Repository navigation
[cleanup][test]delete invalid method in PrometheusMetricsTest - #23218
Merged
Merged
Conversation
nodece
approved these changes
Aug 25, 2024
dao-jun
approved these changes
Aug 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23218 +/- ##
============================================
+ Coverage 73.57% 74.51% +0.93%
- Complexity 32624 33693 +1069
============================================
Files 1877 1922 +45
Lines 139502 144748 +5246
Branches 15299 15832 +533
============================================
+ Hits 102638 107853 +5215
+ Misses 28908 28637 -271
- Partials 7956 8258 +302
Flags with carried forward coverage won't be shown. Click here to find out more. |
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
…#23218) Co-authored-by: account guanyue <account 690010051@qq.com>
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…#23218) Co-authored-by: account guanyue <account 690010051@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I found we defined some methods, but does not used these.
Modifications
Remove the unnecessary method.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: