Skip to content

[cleanup][test]delete invalid method in PrometheusMetricsTest - #23218

Merged
nodece merged 2 commits into
apache:masterfrom
guan46:my-pulsar
Aug 26, 2024
Merged

nodece merged 2 commits into
apache:masterfrom
guan46:my-pulsar

Conversation

@guan46

@guan46 guan46 commented Aug 25, 2024

Copy link
Copy Markdown
Contributor

Motivation

I found we defined some methods, but does not used these.

Modifications

Remove the unnecessary method.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Aug 25, 2024
@nodece nodece added this to the 4.0.0 milestone Aug 25, 2024
@nodece nodece added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Aug 25, 2024
@codecov-commenter

codecov-commenter commented Aug 26, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.51%. Comparing base (bbc6224) to head (3c2bf49).
Report is 552 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23218      +/-   ##
============================================
+ Coverage     73.57%   74.51%   +0.93%     
- Complexity    32624    33693    +1069     
============================================
  Files          1877     1922      +45     
  Lines        139502   144748    +5246     
  Branches      15299    15832     +533     
============================================
+ Hits         102638   107853    +5215     
+ Misses        28908    28637     -271     
- Partials       7956     8258     +302     
Flag Coverage Δ
inttests 27.86% <ø> (+3.28%) ⬆️
systests 24.68% <ø> (+0.36%) ⬆️
unittests 73.86% <ø> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 536 files with indirect coverage changes

@nodece
nodece merged commit a6029ad into apache:master Aug 26, 2024
grssam pushed a commit to grssam/pulsar that referenced this pull request Sep 4, 2024
…#23218)

Co-authored-by: account guanyue <account 690010051@qq.com>
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
…#23218)

Co-authored-by: account guanyue <account 690010051@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants