Skip to content

[fix][broker] Fix delivery-test with unnecessary invocation-count - #23399

Merged
rdhabalia merged 1 commit into
apache:masterfrom
rdhabalia:test_in
Oct 4, 2024
Merged

rdhabalia merged 1 commit into
apache:masterfrom
rdhabalia:test_in

Conversation

@rdhabalia

@rdhabalia rdhabalia commented Oct 4, 2024 •

Copy link
Copy Markdown
Contributor

Motivation

Removing unnecessary invocation count for the unit-test that makes test running unnecessary for multiple times.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@rdhabalia rdhabalia added area/test doc-not-needed Your PR changes do not impact docs ready-to-test labels Oct 4, 2024
@rdhabalia rdhabalia added this to the 4.0.0 milestone Oct 4, 2024
@rdhabalia rdhabalia self-assigned this Oct 4, 2024
@github-actions

github-actions Bot commented Oct 4, 2024

Copy link
Copy Markdown

@rdhabalia Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions Bot added doc-not-needed Your PR changes do not impact docs and removed doc-not-needed Your PR changes do not impact docs doc-label-missing labels Oct 4, 2024
@rdhabalia
rdhabalia merged commit b9ededc into apache:master Oct 4, 2024
@rdhabalia
rdhabalia deleted the test_in branch October 4, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants