chore(deps): bump wheel from 0.46.3 to 0.47.0#8973
Conversation
Bumps [wheel](https://github.com/pypa/wheel) from 0.46.3 to 0.47.0. - [Release notes](https://github.com/pypa/wheel/releases) - [Changelog](https://github.com/pypa/wheel/blob/main/docs/news.rst) - [Commits](pypa/wheel@0.46.3...0.47.0) --- updated-dependencies: - dependency-name: wheel dependency-version: 0.47.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
aws-sam-cli-bot
left a comment
There was a problem hiding this comment.
Code Review Results
Reviewed: 9f13e3d..443a151
Files: 4
Comments: 1
Comments on lines outside the diff:
[requirements/reproducible-linux.txt:81] [GENERAL] This PR is titled bump wheel from 0.46.3 to 0.47.0, but the diff contains substantial changes unrelated to wheel:
binaryornotis downgraded from0.6.0to0.4.4(applied identically inreproducible-linux.txt,reproducible-mac.txt, andreproducible-win.txt).chardet==5.2.0is newly pinned as a transitive dependency (# via binaryornot), introduced becausebinaryornot 0.4.4depends onchardetwhile0.6.0does not.- The matching PyInstaller hook
hooks.collect_all("binaryornot", ...)is removed frominstaller/pyinstaller/hook-samcli.py(the hook was added specifically becausebinaryornot 0.6.0moved its data tables into abinaryornot.datasubpackage).
wheel has no transitive dependency on binaryornot, cookiecutter, or chardet, so these edits are not a natural consequence of bumping wheel. The binaryornot change is specifically a rollback of a prior upgrade (note the existing in-tree comment # binaryornot 0.6.0 moved its binary signature/extension/encoding tables... is also deleted).
Please either:
- Split the
binaryornotrollback (and the correspondingchardetaddition + hook removal) into its own PR with a description explaining why the upgrade is being reverted, or - Update this PR's title/description to reflect the full scope of changes.
Bundling an unrelated transitive-dependency rollback into a Dependabot-style bump wheel PR hurts reviewability (reviewers expect only the advertised bump), makes the change harder to find later in git log, and couples a revert of the wheel bump to a revert of the binaryornot change.
Bumps wheel from 0.46.3 to 0.47.0.
Release notes
Sourced from wheel's releases.
Changelog
Sourced from wheel's changelog.
... (truncated)
Commits
efd83a7Created a new releasebb69216Reordered the changelog entriesd5a1763fix(wheelfile): resolve .dist-info path case-insensitively when reading wheel...5718957[pre-commit.ci] pre-commit autoupdate (#685)6258068chore: log_level is better than log_cli_level (#684)2975debRequire tox >= 4.2247674bachore: add check-sdist to checks (#681)56223f6__package__→__spec__.parent(#679)0ce509eAdded the wheel info subcommand (#669)39039c0Improved the index pageDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)