Skip to content

Allow coredumps to be disabled#657

Merged
chenylee-aws merged 1 commit into
awslabs:masterfrom
chenylee-aws:coredump
Jul 29, 2025
Merged

Allow coredumps to be disabled#657
chenylee-aws merged 1 commit into
awslabs:masterfrom
chenylee-aws:coredump

Conversation

@chenylee-aws

@chenylee-aws chenylee-aws commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

Description of changes:
When enableCoredumps is false, set core file size limits to zero so no core dump is generated to make coredump generation controllable. When unset, default to environment default

[kpl-daemon-0003] INFO software.amazon.kinesis.producer.LogInputStreamReader - [2025-07-25 08:19:53.040517] [0x00054aef][0x00007f4997059240] [info] [main.cc:334] Disabling core dumps: Current soft limit is 18446744073709551615; hard limit is 18446744073709551615; setting soft limit to 0

Updated code to abort() after core dump limit is set and tested three scenarios

  1. unset - core dump file generated
  2. false - not generated
  3. true - generated

Also, run the code without the abort() and code execute without issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread aws/kinesis/main.cc Outdated
@chenylee-aws chenylee-aws changed the title Allow coredump to be disabled Allow coredumps to be disabled Jul 29, 2025
@chenylee-aws chenylee-aws merged commit 2e3ea7e into awslabs:master Jul 29, 2025
@chenylee-aws chenylee-aws deleted the coredump branch July 29, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants