Skip to content

Respect internal monitor config in clamshell recovery - #6353

Merged
dhh merged 1 commit into
basecamp:quattrofrom
zainsyedz:fix-clamshell-internal-monitor-config
Jul 24, 2026
Merged

Respect internal monitor config in clamshell recovery#6353
dhh merged 1 commit into
basecamp:quattrofrom
zainsyedz:fix-clamshell-internal-monitor-config

Conversation

@zainsyedz

Copy link
Copy Markdown
Contributor

Summary

  • parse explicit internal monitor rules from ~/.config/hypr/monitors.lua before falling back to omarchy_monitor_scale
  • preserve the configured internal monitor position when re-enabling the panel after clamshell recovery
  • add regression coverage for configured internal scale and position

Tests

  • bash test/shell.d/monitor-clamshell-scale-test.sh
  • bash -n bin/omarchy-hyprland-monitor-clamshell test/shell.d/monitor-clamshell-scale-test.sh

Copilot AI review requested due to automatic review settings July 23, 2026 09:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Omarchy’s clamshell recovery monitor logic to honor explicit internal-monitor rules from ~/.config/hypr/monitors.lua, ensuring the internal monitor’s configured scale and position are applied when re-enabling the panel after clamshell recovery, and adds regression tests for these scenarios.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Changes:

  • Prefer explicit internal-monitor hl.monitor(...) rules for scale (and newly for position) before falling back to omarchy_monitor_scale.
  • Apply the configured internal monitor position (instead of always using auto) when re-enabling the internal output.
  • Add shell test coverage for configured internal monitor position + scale during recovery.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
bin/omarchy-hyprland-monitor-clamshell Parses internal monitor scale/position from monitors.lua and uses that position when re-enabling the internal output.
test/shell.d/monitor-clamshell-scale-test.sh Adds regression assertions for configured internal monitor position + scale during clamshell recovery.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dhh
dhh merged commit 1d40772 into basecamp:quattro Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants