Respect internal monitor config in clamshell recovery - #6353
Merged
dhh merged 1 commit intoJul 24, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Omarchy’s clamshell recovery monitor logic to honor explicit internal-monitor rules from ~/.config/hypr/monitors.lua, ensuring the internal monitor’s configured scale and position are applied when re-enabling the panel after clamshell recovery, and adds regression tests for these scenarios.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Prefer explicit internal-monitor
hl.monitor(...)rules forscale(and newly forposition) before falling back toomarchy_monitor_scale. - Apply the configured internal monitor position (instead of always using
auto) when re-enabling the internal output. - Add shell test coverage for configured internal monitor position + scale during recovery.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bin/omarchy-hyprland-monitor-clamshell | Parses internal monitor scale/position from monitors.lua and uses that position when re-enabling the internal output. |
| test/shell.d/monitor-clamshell-scale-test.sh | Adds regression assertions for configured internal monitor position + scale during clamshell recovery. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests