Merged
Conversation
added 2 commits
October 23, 2024 09:39
berkayoz
reviewed
Oct 23, 2024
Member
berkayoz
left a comment
berkayoz
left a comment
There was a problem hiding this comment.
I'm not too happy about this workaround, this feels like just masking the underlying issue. The safe directory wildcard also feels too wide, could we deem certain directories as safe instead of any?
Contributor
Author
How about narowing it to |
berkayoz
reviewed
Nov 6, 2024
berkayoz
approved these changes
Nov 8, 2024
This reverts commit 5bbbc2b.
maci3jka
deleted the
KU-1812/enable-git-safe-dir-when-non-root-enable-addon
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues when non-root user in non-strict environment tries to enable community addons.
Closes #4574
Changes
added temporary setting to git to ingnore
Testing
enabled and disabled community addon
Possible Regressions
n/a
Checklist
Notes