Skip to content

Consistent option names pt1#2314

Merged
etimberg merged 9 commits into
chartjs:masterfrom
jachstet-sea:consistent_option_names_pt1
Apr 23, 2016
Merged

Consistent option names pt1#2314
etimberg merged 9 commits into
chartjs:masterfrom
jachstet-sea:consistent_option_names_pt1

Conversation

@jachstet-sea

Copy link
Copy Markdown
Contributor

Okay, first changeset, changing only tension -> lineTension. Feel free to comment on stuff you don't like.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 71.957% when pulling 4d4271e on jachstet-sea:consistent_option_names_pt1 into 13e0387 on nnnick:master.

@tannerlinsley

Copy link
Copy Markdown
Contributor

Looking good!

@jachstet-sea

Copy link
Copy Markdown
Contributor Author

Glad to hear. Working on doing the same for the point-options now

@etimberg

Copy link
Copy Markdown
Member

Looks good

@jachstet-sea

Copy link
Copy Markdown
Contributor Author

Allright, I just pushed part 2 but kept the branch name so it goes into this PR.
I also added a new sample that showcases how to use the different point size options.
Feel free to merge, I consider this done if there are no change-requests from your side.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.07%) to 72.007% when pulling b21d147 on jachstet-sea:consistent_option_names_pt1 into 13e0387 on nnnick:master.

@jachstet-sea

Copy link
Copy Markdown
Contributor Author

And just to have a reference: fixes #2307

@etimberg

Copy link
Copy Markdown
Member

@tannerlinsley feel free to merge

@etimberg etimberg merged commit 32db92c into chartjs:master Apr 23, 2016
@jachstet-sea jachstet-sea deleted the consistent_option_names_pt1 branch April 25, 2016 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants