📂 fix: Respect supportedMimeTypes Config in File Picker Accept Filter#12596
Merged
Conversation
The browser file picker's accept attribute was hardcoded by provider identity, ignoring the endpoint's supportedMimeTypes from fileConfig. Users who configured permissive MIME types (e.g., '.*') still saw a restrictive filter in the upload dialog. Add isPermissiveMimeConfig utility that detects wildcard patterns in the endpoint's supportedMimeTypes. When permissive, the file picker accept attribute is set to empty (unrestricted). Non-permissive configs retain the existing provider-based defaults. Closes #12589
danny-avila
force-pushed
the
fix/file-picker-accept-mime-config
branch
from
29b54a9 to
0dc2c16
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the frontend file picker’s accept filter so endpoints configured with permissive supportedMimeTypes (e.g., '.*') don’t show an artificially restrictive file-type dialog, aligning the UI with the effective backend MIME handling.
Changes:
- Add
isPermissiveMimeConfig()inpackages/data-providerand unit tests to detect permissive MIME regex configurations. - Update
AttachFileMenuto clear the file inputacceptfilter when the endpoint MIME config is permissive. - Add GitNexus indexing + Fly.io deployment workflows/config (not described in the PR metadata and operationally significant).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/data-provider/src/file-config.ts | Adds isPermissiveMimeConfig() helper for permissive MIME regex detection. |
| packages/data-provider/src/file-config.spec.ts | Adds unit tests for isPermissiveMimeConfig() (including convertStringsToRegex path). |
| client/src/components/Chat/Input/Files/AttachFileMenu.tsx | Clears the accept attribute for permissive endpoint MIME configs to avoid restrictive picker filters. |
| .github/workflows/gitnexus-index.yml | Adds a new CI workflow to generate and upload a GitNexus index artifact. |
| .github/workflows/gitnexus-deploy.yml | Adds workflow to deploy the GitNexus index to Fly.io (includes security-sensitive setup guidance). |
| .fly/gitnexus/fly.toml | Adds Fly.io app configuration for the GitNexus service. |
| .fly/gitnexus/entrypoint.sh | Adds container entrypoint to run gitnexus serve behind Caddy. |
| .fly/gitnexus/Dockerfile | Adds container build for GitNexus + Caddy, consuming the CI-produced index artifact. |
| .fly/gitnexus/Caddyfile | Adds bearer-token auth proxy configuration for the GitNexus service. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Use non-standard MIME namespace probe (x-librechat/x-probe) so category-wildcard patterns like ^application\/.*$ no longer false-positive as permissive - Add single-line JSDoc to isPermissiveMimeConfig - Use !== undefined instead of != null (fileType is never null) - Add endpointFileConfig to dropdownItems useMemo deps to prevent stale closure when config changes without endpoint change - Add tests for broad application and multi-category patterns
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
handleUploadClick is captured inside the dropdownItems useMemo but was not in its dependency array. Wrap it in useCallback with endpointFileConfig.supportedMimeTypes as the sole dependency, then reference the stable callback in the useMemo deps.
danny-avila
changed the title
supportedMimeTypes Config in File Picker Accept Filter
yidianyiko
pushed a commit
to yidianyiko/LibreChat
that referenced
this pull request
Apr 13, 2026
…er (danny-avila#12596) * fix: respect supportedMimeTypes config in file picker accept filter The browser file picker's accept attribute was hardcoded by provider identity, ignoring the endpoint's supportedMimeTypes from fileConfig. Users who configured permissive MIME types (e.g., '.*') still saw a restrictive filter in the upload dialog. Add isPermissiveMimeConfig utility that detects wildcard patterns in the endpoint's supportedMimeTypes. When permissive, the file picker accept attribute is set to empty (unrestricted). Non-permissive configs retain the existing provider-based defaults. Closes danny-avila#12589 * fix: address review findings for isPermissiveMimeConfig - Use non-standard MIME namespace probe (x-librechat/x-probe) so category-wildcard patterns like ^application\/.*$ no longer false-positive as permissive - Add single-line JSDoc to isPermissiveMimeConfig - Use !== undefined instead of != null (fileType is never null) - Add endpointFileConfig to dropdownItems useMemo deps to prevent stale closure when config changes without endpoint change - Add tests for broad application and multi-category patterns * fix: wrap handleUploadClick in useCallback to satisfy exhaustive-deps handleUploadClick is captured inside the dropdownItems useMemo but was not in its dependency array. Wrap it in useCallback with endpointFileConfig.supportedMimeTypes as the sole dependency, then reference the stable callback in the useMemo deps.
jcbartle
pushed a commit
to jcbartle/LibreChat
that referenced
this pull request
May 11, 2026
…er (danny-avila#12596) * fix: respect supportedMimeTypes config in file picker accept filter The browser file picker's accept attribute was hardcoded by provider identity, ignoring the endpoint's supportedMimeTypes from fileConfig. Users who configured permissive MIME types (e.g., '.*') still saw a restrictive filter in the upload dialog. Add isPermissiveMimeConfig utility that detects wildcard patterns in the endpoint's supportedMimeTypes. When permissive, the file picker accept attribute is set to empty (unrestricted). Non-permissive configs retain the existing provider-based defaults. Closes danny-avila#12589 * fix: address review findings for isPermissiveMimeConfig - Use non-standard MIME namespace probe (x-librechat/x-probe) so category-wildcard patterns like ^application\/.*$ no longer false-positive as permissive - Add single-line JSDoc to isPermissiveMimeConfig - Use !== undefined instead of != null (fileType is never null) - Add endpointFileConfig to dropdownItems useMemo deps to prevent stale closure when config changes without endpoint change - Add tests for broad application and multi-category patterns * fix: wrap handleUploadClick in useCallback to satisfy exhaustive-deps handleUploadClick is captured inside the dropdownItems useMemo but was not in its dependency array. Wrap it in useCallback with endpointFileConfig.supportedMimeTypes as the sole dependency, then reference the stable callback in the useMemo deps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The browser file picker's
acceptattribute was hardcoded by provider identity inAttachFileMenu.tsx, ignoring the endpoint'ssupportedMimeTypesfromfileConfig. PR #12508 fixed the backend routing so custom MIME types are processed correctly, but the frontend file picker dialog still showed a restrictive filter — confusing users who configured permissive types likesupportedMimeTypes: ['.*'].isPermissiveMimeConfigutility inpackages/data-provider/src/file-config.tsthat detects wildcard patterns by testing a synthetic MIME type (application/x-librechat-any) against the endpoint'ssupportedMimeTypesRegExp arrayhandleUploadClickthat sets the file inputacceptto''(unrestricted) when the endpoint's MIME config is permissive, short-circuiting the hardcoded provider-based strings/.*/,/.+/,/^.*$/,/^.+$/), mixed arrays, category patterns, specific MIME types, defaults, edge cases, and the end-to-endconvertStringsToRegex→isPermissiveMimeConfigpathCloses #12589
Change Type
Testing
fileConfig.endpoints.custom.supportedMimeTypes: ['.*']inlibrechat.yamlcd packages/data-provider && npx jest file-config --verbose— all 113 tests passChecklist