The glassfish-grizzly-extra-all produces invalid manifest headers

[dmatej]

OSGi doesn't like maven snapshots and uses them as classifiers.
However I am not sure if they are ever used, I just noticed the Felix plugin reported it:

mvn clean install -pl :glassfish-grizzly-extra-all -Dgrizzly.version=5.0.3-SNAPSHOT
# Note: Without the grizzly snapshot it still prints one warning.
...
[WARNING] Bundle org.glassfish.main.grizzly:glassfish-grizzly-extra-all:jar:8.0.2-SNAPSHOT : Version for package org.glassfish.grizzly.comet is set to different values in the source (5.0.2-SNAPSHOT) and in the manifest (5.0.2). The version in the manifest is not picked up by an other sibling bundles in this project or projects that directly depend on this project
[WARNING] Bundle org.glassfish.main.grizzly:glassfish-grizzly-extra-all:jar:8.0.2-SNAPSHOT : Version for package org.glassfish.grizzly.comet.concurrent is set to different values in the source (5.0.2-SNAPSHOT) and in the manifest (5.0.2). The version in the manifest is not picked up by an other sibling bundles in this project or projects that directly depend on this project
[WARNING] Bundle org.glassfish.main.grizzly:glassfish-grizzly-extra-all:jar:8.0.2-SNAPSHOT : Version for package org.glassfish.grizzly.websockets is set to different values in the source (5.0.2-SNAPSHOT) and in the manifest (5.0.2). The version in the manifest is not picked up by an other sibling bundles in this project or projects that directly depend on this project
[WARNING] Bundle org.glassfish.main.grizzly:glassfish-grizzly-extra-all:jar:8.0.2-SNAPSHOT : Version for package org.glassfish.grizzly.websockets.frametypes is set to different values in the source (5.0.2-SNAPSHOT) and in the manifest (5.0.2). The version in the manifest is not picked up by an other sibling bundles in this project or projects that directly depend on this project
[WARNING] Bundle org.glassfish.main.grizzly:glassfish-grizzly-extra-all:jar:8.0.2-SNAPSHOT : Version for package org.glassfish.grizzly.websockets.glassfish is set to different values in the source (5.0.2-SNAPSHOT) and in the manifest (5.0.2). The version in the manifest is not picked up by an other sibling bundles in this project or projects that directly depend on this project
[WARNING] Bundle org.glassfish.main.grizzly:glassfish-grizzly-extra-all:jar:8.0.2-SNAPSHOT : Version for package org.glassfish.grizzly.websockets.rfc6455 is set to different values in the source (5.0.2-SNAPSHOT) and in the manifest (5.0.2). The version in the manifest is not picked up by an other sibling bundles in this project or projects that directly depend on this project
[WARNING] Bundle org.glassfish.main.grizzly:glassfish-grizzly-extra-all:jar:8.0.2-SNAPSHOT : Version for package org.glassfish.grizzly.http.ajp is set to different values in the source (5.0.2-SNAPSHOT) and in the manifest (5.0.2). The version in the manifest is not picked up by an other sibling bundles in this project or projects that directly depend on this project
[WARNING] Bundle org.glassfish.main.grizzly:glassfish-grizzly-extra-all:jar:8.0.2-SNAPSHOT : Version for package org.glassfish.grizzly.servlet is set to different values in the source (5.0.2-SNAPSHOT) and in the manifest (5.0.2). The version in the manifest is not picked up by an other sibling bundles in this project or projects that directly depend on this project
[WARNING] Bundle org.glassfish.main.grizzly:glassfish-grizzly-extra-all:jar:8.0.2-SNAPSHOT : Version for package org.glassfish.extras.grizzly is set to different values in the source (8.0.2-SNAPSHOT) and in the manifest (8.0.2). The version in the manifest is not picked up by an other sibling bundles in this project or projects that directly depend on this project

                        <Export-Package>
                            org.glassfish.grizzly.comet.*;version=${grizzly.version},
                            org.glassfish.grizzly.websockets.*;version=${grizzly.version},
                            org.glassfish.grizzly.http.ajp.*;version=${grizzly.version},
                            org.glassfish.grizzly.servlet.*;version=${grizzly.version},
                            org.glassfish.grizzly.extras.*;version=${project.version},
                            org.glassfish.extras.grizzly.*;version=${project.version}
                        </Export-Package>

There are two options:

• Delete it, then this artifact would be used just as some "transport box dependency" for other modules
• Fix it, generate proper osgi version property.

Recommendation: try first without any instructions and compare results.

[renatsaf]

Hi @dmatej. I asked Claude to analyze the issue.

[renatsaf]

@
Analysis of the invalid manifest headers

The warning is bnd telling us that the version we ask for and the version it writes disagree:

• source = the literal POM value, e.g. version=${project.version} -> 8.0.3-SNAPSHOT
• manifest = what actually lands in MANIFEST.MF -> 8.0.3

Root cause: a Maven version is not a valid OSGi version. OSGi uses major.minor.micro[.qualifier] with a dot before the qualifier (8.0.3.SNAPSHOT); Maven uses a hyphen (8.0.3-SNAPSHOT). When bnd receives the hyphenated string as an Export-Package attribute it cannot parse -SNAPSHOT as a qualifier, truncates it to 8.0.3, and warns that the value will not be picked up by sibling/dependent bundles.

The offending lines are in glassfish-grizzly-extra-all/pom.xml:

org.glassfish.grizzly.comet.*;version=${grizzly.version},
org.glassfish.grizzly.websockets.*;version=${grizzly.version},
org.glassfish.grizzly.http.ajp.*;version=${grizzly.version},
org.glassfish.grizzly.servlet.*;version=${grizzly.version},
org.glassfish.grizzly.extras.*;version=${project.version},
org.glassfish.extras.grizzly.*;version=${project.version}

One detail vs. the original report: it was filed when grizzly.version was 5.0.2-SNAPSHOT. Today grizzly.version is pinned to the release 5.0.1 (in nucleus/parent/pom.xml), so the four ${grizzly.version} lines do not warn right now - but the two ${project.version} lines (8.0.3-SNAPSHOT) still do, and the Grizzly lines will break again as soon as Grizzly returns to a SNAPSHOT. So the root cause is unaddressed.

Which version belongs to which package:

• org.glassfish.grizzly.extras.* - source is in this module -> correctly project.version
• org.glassfish.extras.grizzly.* - from the grizzly-container module (no OSGi config of its own) -> also project.version
• the four org.glassfish.grizzly.* packages are repackaged from external Grizzly jars -> belong to grizzly.version

On the two options you listed:

The sibling module nucleus-grizzly-all is a useful precedent - it runs maven-bundle-plugin but exports org.glassfish.grizzly.* with no explicit versions, letting bnd derive Bundle-Version (which does get the proper -SNAPSHOT -> .SNAPSHOT conversion). That matches your "try first without any instructions and compare results" suggestion.

I would go with: drop the explicit ;version=... attributes (or the whole <instructions> block), rebuild, and diff the generated MANIFEST.MF against the current one. If the only change is the qualifiers becoming valid OSGi versions and no consumer relies on the old values, that is the fix - it removes the warning permanently and survives Grizzly going back to SNAPSHOT.

I can prepare a PR with that change plus the before/after manifest diff if you are happy with the direction.
@

[dmatej]

God, so many lines to repeat what was already written ... it is a known issue wide spread in the past, I just noticed it here again and created an issue before I forget it.

If you want, you can create a PR, it would be helpful, just ask to set label In Progress before you start, so I would know you are working on it and I would not duplicate your work. Thank you!

[renatsaf]

I'm ready to create the PR.

[OndroMih]

This warning is valid for releases, which shouldn't depend on SNAPSHOT versions but should be ignored for SNAPSHOT versions.

I found out that the bundle plugin can be configured to turn the message either to an ERROR (to fail the build) or ignore it.

I suggest that we do the following:

• configure the bundle plugin, with a maven property
• set the maven property to ERROR by default, so that release builds fail if there are snapshots
• set the maven property to IGNORE by a build helper plugin if project.version ends with -SNAPSHOT

Like this:

<properties>
    <bnd.version.mismatch.level>error</bnd.version.mismatch.level>
</properties>

<build>
    <plugins>
        <plugin>
            <groupId>org.codehaus.mojo</groupId>
            <artifactId>build-helper-maven-plugin</artifactId>
            <executions>
                <execution>
                    <id>bnd-version-mismatch-level</id>
                    <goals>
                        <goal>regex-property</goal>
                    </goals>
                    <configuration>
                        <name>bnd.version.mismatch.level</name>
                        <value>${project.version}</value>
                        <regex>.*-SNAPSHOT</regex>
                        <replacement>ignore</replacement>
                        <failIfNoMatch>false</failIfNoMatch>
                    </configuration>
                </execution>
            </executions>
        </plugin>

        <plugin>
            <groupId>org.apache.felix</groupId>
            <artifactId>maven-bundle-plugin</artifactId>
            <configuration>
                <instructions>
                    <_fixupmessages>"Version for package * is set to different values*";restrict:=warning;is:=${bnd.version.mismatch.level}</_fixupmessages>
                </instructions>
            </configuration>
        </plugin>
    </plugins>
</build>

[renatsaf]

This warning is valid for releases, which shouldn't depend on SNAPSHOT versions but should be ignored for SNAPSHOT versions.

I found out that the bundle plugin can be configured to turn the message either to an ERROR (to fail the build) or ignore it.

I suggest that we do the following:

* configure the bundle plugin, with a maven property

* set the maven property to ERROR by default, so that release builds fail if there are snapshots

* set the maven property to IGNORE by a build helper plugin if project.version ends with -SNAPSHOT

Like this:

<properties>
    <bnd.version.mismatch.level>error</bnd.version.mismatch.level>
</properties>

<build>
    <plugins>
        <plugin>
            <groupId>org.codehaus.mojo</groupId>
            <artifactId>build-helper-maven-plugin</artifactId>
            <executions>
                <execution>
                    <id>bnd-version-mismatch-level</id>
                    <goals>
                        <goal>regex-property</goal>
                    </goals>
                    <configuration>
                        <name>bnd.version.mismatch.level</name>
                        <value>${project.version}</value>
                        <regex>.*-SNAPSHOT</regex>
                        <replacement>ignore</replacement>
                        <failIfNoMatch>false</failIfNoMatch>
                    </configuration>
                </execution>
            </executions>
        </plugin>

        <plugin>
            <groupId>org.apache.felix</groupId>
            <artifactId>maven-bundle-plugin</artifactId>
            <configuration>
                <instructions>
                    <_fixupmessages>"Version for package * is set to different values*";restrict:=warning;is:=${bnd.version.mismatch.level}</_fixupmessages>
                </instructions>
            </configuration>
        </plugin>
    </plugins>
</build>

Hi @OndroMih . I asked Claude to Implement the feedback.

[renatsaf]

@
PR #26055 now implements @OndroMihs parent-pom approach: a _fixupmessages instruction in nucleus/parent plus a build-helper regex-property that sets the level to ignore for -SNAPSHOT builds and error for releases. This fixes the whole class of warnings centrally rather than per module.

One adjustment: regex-property does not overwrite an already-set property, so the predefined error default never relaxed to ignore — I compute the level in two steps with a fresh property instead. Verified: SNAPSHOT build of glassfish-grizzly-extra-all emits zero warnings and keeps valid OSGi versions.
@