Avoid going through Optional - #26138
Merged
Merged
Conversation
pzygielo
marked this pull request as ready for review
July 8, 2026 13:44
dmatej
approved these changes
Jul 9, 2026
| Stream<File> libs = findFiles(appInstall, libFilter); | ||
| Stream<File> derbyLibs = findFiles(derbyLibDir, derbyFilter); | ||
| return Stream.of(modules, libs, derbyLibs).reduce(Stream::concat).orElseGet(Stream::empty).map(TO_URL) | ||
| return Stream.of(modules, libs, derbyLibs).flatMap(s -> s).map(TO_URL) |
Contributor
There was a problem hiding this comment.
s -> s is the same as Function.identity(), am I right?
But ... where is the Optional? Aha, I see, the original code's Stream.reduce method returns Optional<Stream<File>>, while Stream.empty returns Stream<File>.
And you are right:
"Each mapped stream is closed after its contents have been placed into this stream. (If a mapped stream is null an empty stream is used, instead.)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.