Improve ECA documentation in CONTRIBUTING.md - #7299
Merged
Merged
Conversation
Contributor
Author
|
@mstoodle : would you mind reviewing please? |
mstoodle
requested changes
Apr 3, 2024
mstoodle
left a comment
mstoodle
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks very good, thanks for pulling this together
| request), a webservice will automatically run that will verify that each commit | ||
| author's email address matches an email address that signed the ECA. | ||
| **This service is case-sensitive, so the case of the email addresses must match exactly.** | ||
| The success or failure of this webservice will be reported in the GitHub pull request. |
Contributor
There was a problem hiding this comment.
The only thing I would add here is a more explicit comment that pull requests that fail the ECA check will not be merged.
Contributor
Author
There was a problem hiding this comment.
Fixed in forced push.
Make ECA requirements more prominent in the contribution guidelines. Includes minor edits to miscellaneous text for readability. This was feedback from a recent OMR release review. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
mstoodle
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ECA requirements more prominent in the contribution guidelines.
Includes minor edits to miscellaneous text for readability.
This was feedback from a recent OMR release review.