Use genLoadProfiledClassAddressConstant in Z codegen

[Spencer-Comin]

Replaces this sort of idiom:

if (cg->needClassAndMethodPointerRelocations())
   temp = generateRegLitRefInstruction(cg, TR::InstOpCode::getLoadOpCode(), node, arbitraryClassReg1, (uintptr_t) profiledClassesList[numPICs].profiledClass, TR_ClassPointer, NULL, NULL, NULL);
else
   temp = generateRILInstruction(cg, TR::InstOpCode::LARL, node, arbitraryClassReg1, profiledClassesList[numPICs].profiledClass);

if (fej9->isUnloadAssumptionRequired((TR_OpaqueClassBlock *)(profiledClassesList[numPICs].profiledClass), comp->getCurrentMethod()))
   comp->getStaticPICSites()->push_front(temp);
if (cg->wantToPatchClassPointer(profiledClassesList[numPICs].profiledClass, node))
   comp->getStaticHCRPICSites()->push_front(temp);

with a call to the genLoadProfiledClassAddressConstant helper.

See the OMR PR for the implementation of genLoadProfiledClassAddressConstant.

[r30shah]

@Spencer-Comin Can you confirm if the replacement adds the PICSites to HCRPICSites list as well?

[Spencer-Comin]

@Spencer-Comin Can you confirm if the replacement adds the PICSites to HCRPICSites list as well?

It does not, I will change it to include that

[Spencer-Comin]

Once eclipse-omr/omr#6596 goes through, the PICSites will be added to the HCRPICSites list

[Spencer-Comin]

FYI @joransiu @r30shah

[r30shah]

@Spencer-Comin This change looks good to me, as this would be dependent OMR, can you mark this one WIP.

[r30shah]

Hi @joransiu would it be possible to launch jenkins test on this PR that depends on eclipse-omr/omr#6596, OMR one is good to merge and I expect it to get merged today

[joransiu]

Jenkins test sanity zlinux jdk17,jdk20 depends eclipse-omr/omr#6596

[r30shah]

@Spencer-Comin both JDK17 and JDK20 build seemed to failed building jIT can you check ?

[Spencer-Comin]

It looks unrelated to my changes. I'll rebase and hopefully that resolves it.

[joransiu]

Jenkins test sanity zlinux jdk17,jdk20 depends eclipse-omr/omr#6596

[joransiu]

Yeah, it's odd... the line number flagged matches the latest version of ValueTypeHelpers.hpp, and the use of the variable is there later on in the method: https://github.com/eclipse-openj9/openj9/blob/master/runtime/vm/ValueTypeHelpers.hpp#L646.

[joransiu]

Jenkins compile zlinux jdk11