Fix issues with non-SVM aconst_init AOT compilation - #15460
Merged
Conversation
Contributor
Author
|
@jdmpapin May I ask you to review this change? Thank you! |
Contributor
Author
|
@hzongaro fyi |
Contributor
Author
|
@jdmpapin Just following up. Could you help review this change? Thanks! |
jdmpapin
reviewed
Jul 20, 2022
jdmpapin
left a comment
jdmpapin
left a comment
Contributor
There was a problem hiding this comment.
Changes look reasonable at a high level but there are a few problems. Also, it might be good to mention somewhere in the commit message that aconst_init of a value type with a Q-typed field will now cause ilgen to fail in non-SVM AOT compilations
hzongaro
reviewed
Jul 21, 2022
a7ehuo
force-pushed
the
enable-AOT-aconst-init-2
branch
from
July 21, 2022 18:27
a546c66 to
a59bddb
Compare
jdmpapin
approved these changes
Jul 21, 2022
Contributor
|
@hzongaro, do you have any further feedback? |
hzongaro
reviewed
Jul 22, 2022
ILGen: - Pass `returnClassForAOT` as true in getClassFromConstantPool which is required to retrieve class in non-SVM AOT compilation - Pass `cpIndex` in findOrCreateClassSymbol which is required for `TR_ClassAddress` relocation record - When generating IL for `aconst_init`, if the class has a field which is also value type, the non-SVM AOT compilation is aborted in ILGen because the `cpIndex` for the field is unknown and it is required to materialize the class in AOT load - Update `genWithField` and `genFlattenableWithField` to use `int32_t` instead of `uint16_t` for their cpIndex arguments X86: - Evaluate the class into a register for loadaddr under new - Use ASSERT_FATAL if the classReg is NULL in non-SVM AOT Fixes: eclipse-openj9#15423, eclipse-openj9#15424 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
enable-AOT-aconst-init-2
branch
from
July 22, 2022 15:24
a59bddb to
223f29e
Compare
Contributor
Author
hzongaro
approved these changes
Jul 25, 2022
hzongaro
left a comment
hzongaro
left a comment
Member
There was a problem hiding this comment.
Looks good. Thanks, Annabelle!
Contributor
|
Jenkins test sanity xlinuxval,xlinuxvalst,plinuxval,plinuxvalst,zlinuxval,zlinuxvalst,alinuxval,alinuxvalst jdknext |
Contributor
|
Jenkins test sanity all jdk17 |
Contributor
Author
|
AIX build failure doesn't look related to this change. There is a crash in openjdknext_j9_sanity.functional_s390x_linux_vt_standard.. I'm still looking |
Contributor
|
The AIX build failure is #8625 - retrying Jenkins test sanity aix jdk17 |
Contributor
Author
|
This PR doesn't contain any code that could affect |
Contributor
|
OK, I can confirm that the crash has been observed elsewhere as described in the previous comment, so it's unrelated to this PR |
Contributor
|
All other tests have passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ILGen:
returnClassForAOTas ingetClassFromConstantPoolwhich is required to retrieve class in non-SVM AOT compilationfindOrCreateClassSymbolwhich is required forTR_ClassAddressrelocation recordaconst_init, if the class has a field which is also value type, the non-SVM AOT compilation is aborted in ILGen because thecpIndexfor the field is unknown and it is required to materialize the class in AOT loadgenWithFieldmethods andgenFlattenableWithFieldto useint32_tinstead ofuint16_tfor their cpIndex argumentsX86:
Fixes: #15423, #15424
Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com