Skip to content

Continuation: pin and unpin implementation - #15461

Merged
DanHeidinga merged 1 commit into
eclipse-openj9:masterfrom
babsingh:loom_pin_support
Jul 2, 2022
Merged

Continuation: pin and unpin implementation#15461
DanHeidinga merged 1 commit into
eclipse-openj9:masterfrom
babsingh:loom_pin_support

Conversation

@babsingh

Copy link
Copy Markdown
Contributor
  • Continuation.pin(): Increment the counter to pin a continuation. Throws
    IllegalStateException in case of an overflow.
  • Continuation.unpin(): Decrement the counter to unpin a continuation. Throws
    IllegalStateException in case of an underflow.

Related: #15174

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

Comment thread runtime/jcl/common/jdk_internal_vm_Continuation.cpp Outdated
Comment thread runtime/jcl/common/jdk_internal_vm_Continuation.cpp Outdated
@babsingh
babsingh marked this pull request as ready for review June 30, 2022 14:38

@DanHeidinga DanHeidinga left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga

Copy link
Copy Markdown
Member

Jenkins test sanity xlinux jdk19

Comment thread runtime/jcl/common/jdk_internal_vm_Continuation.cpp Outdated
- Continuation.pin(): Increment the counter to pin a continuation. Throws
  IllegalStateException in case of an overflow.
- Continuation.unpin(): Decrement the counter to unpin a continuation. Throws
  IllegalStateException in case of an underflow.

Related: eclipse-openj9#15174

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@JasonFengJ9

Copy link
Copy Markdown
Member

The PR build[1] is still valid, sanity.functional test is in progress.

[1] https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/2382

Comment thread runtime/jcl/common/jdk_internal_vm_Continuation.cpp
@tajila

tajila commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

jenkins compile win jdk19

@DanHeidinga
DanHeidinga merged commit 0e480f2 into eclipse-openj9:master Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants