Stop trusting parameter types for bastore in DLT - #15543
Merged
0xdaryl merged 1 commit intoJul 20, 2022
Merged
Conversation
The bytecode may have stored a byte[] reference into a boolean[] parameter slot, or vice versa, on a path that does not get translated into IL for the DLT compilation. In that case, the compiler could incorrectly treat certain bstorei nodes as though the array type is known based on the signature of a parameter.
Contributor
Author
Contributor
|
Jenkins test sanity all jdk17 |
0xdaryl
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bytecode may have stored a
byte[]reference into aboolean[]parameter slot, or vice versa, on a path that does not get translated into IL for the DLT compilation. In that case, the compiler could incorrectly treat certainbstoreinodes as though the array type is known based on the signature of a parameter.