Skip to content

Disable LocalSyncCompiles under FullSpeedDebug - #15686

Merged
mpirvu merged 1 commit into
eclipse-openj9:masterfrom
cjjdespres:fsd-fix
Aug 10, 2022
Merged

Disable LocalSyncCompiles under FullSpeedDebug#15686
mpirvu merged 1 commit into
eclipse-openj9:masterfrom
cjjdespres:fsd-fix

Conversation

@cjjdespres

Copy link
Copy Markdown
Contributor

The JITServerLocalSyncCompiles option causes remote recompilations to
be scheduled after synchronous JIT compilations. This is incompatible
with FullSpeedDebug, which is supposed to disable recompilations.

Signed-off-by: Christian Despres despresc@ibm.com

@cjjdespres

Copy link
Copy Markdown
Contributor Author

Attn @mpirvu. I've still only tested DaaLoadTest_all_special_5m_18. Would you like me to grind the rest of the failing tests?

Comment thread runtime/compiler/control/J9Options.cpp Outdated
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Aug 9, 2022
@mpirvu

mpirvu commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Would you like me to grind the rest of the failing tests?

Yes, please.

The JITServerLocalSyncCompiles option causes remote recompilations to
be scheduled after synchronous JIT compilations. This is incompatible
with FullSpeedDebug, which is supposed to disable recompilations.

Signed-off-by: Christian Despres <despresc@ibm.com>

@mpirvu mpirvu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu

mpirvu commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit jdk17

@mpirvu

mpirvu commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

There was a timeout on pLinux for cmdLineTester_gcsuballoctests_0

===============================================
Running test cmdLineTester_gcsuballoctests_0 ...
===============================================
cmdLineTester_gcsuballoctests_0 Start Time: Wed Aug 10 01:47:53 2022 Epoch Time (ms): 1660110473817
variation: Mode610
JVM_OPTIONS: -XX:+UseJITServer -Xcompressedrefs -Xjit -Xgcpolicy:gencon 
Parsing exclude list...
  add excludes for [all]
  add excludes for [linux_ppc-64]
DONE in 0 ms.

No tests are excluded.

*** Starting test suite: J9 GC  Tests ***
Testing: -Xgc:suballocatorInitialSize=100m
Test start time: 2022/08/10 01:48:24 Eastern Standard Time
Running command: "/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_ppc64le_linux_jit_Personal_testList_0/openjdkbinary/j2sdk-image/bin/java" -XX:+UseJITServer -Xcompressedrefs -Xjit -Xgcpolicy:gencon  -Xgc:suballocatorInitialSize=100m -version
Time spent starting: 83 milliseconds
***[TEST INFO 2022/08/10 01:49:24] ProcessKiller detected a timeout after 60000 milliseconds!***
INFO: Cannot find '/usr/bin/gdb' using 'gdb' from the path.
Time spent executing: 60147 milliseconds
Test result: FAILED

@mpirvu

mpirvu commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

I don't know why the test on x86 was aborted. No test in particular has timed out, but maybe the entire test sequence took too long.

@mpirvu

mpirvu commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

jenkins test sanity plinuxjit,xlinuxjit jdk17

@cjjdespres

Copy link
Copy Markdown
Contributor Author

The failing X tests all pass, 15x. https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/26628/.

@mpirvu

mpirvu commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

pLinux again failed cmdLineTester_gcsuballoctests_0

===============================================
Running test cmdLineTester_gcsuballoctests_0 ...
===============================================
cmdLineTester_gcsuballoctests_0 Start Time: Wed Aug 10 15:55:14 2022 Epoch Time (ms): 1660161314074
variation: Mode610
JVM_OPTIONS: -XX:+UseJITServer -Xcompressedrefs -Xjit -Xgcpolicy:gencon 
Parsing exclude list...
  add excludes for [all]
  add excludes for [linux_ppc-64]
DONE in 0 ms.

No tests are excluded.

*** Starting test suite: J9 GC  Tests ***
Testing: -Xgc:suballocatorInitialSize=100m
Test start time: 2022/08/10 15:55:44 Eastern Standard Time
Running command: "/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_ppc64le_linux_jit_Personal_testList_0/openjdkbinary/j2sdk-image/bin/java" -XX:+UseJITServer -Xcompressedrefs -Xjit -Xgcpolicy:gencon  -Xgc:suballocatorInitialSize=100m -version
Time spent starting: 96 milliseconds
***[TEST INFO 2022/08/10 15:56:45] ProcessKiller detected a timeout after 60000 milliseconds!***
INFO: Cannot find '/usr/bin/gdb' using 'gdb' from the path.
Time spent executing: 60154 milliseconds
Test result: FAILED
Output from test:
 [ERR] openjdk version "17.0.5-internal" 2022-10-18
 [ERR] OpenJDK Runtime Environment (build 17.0.5-internal+0-adhoc.jenkins.BuildJDK17ppc64lelinuxjitPersonal)
 [ERR] Eclipse OpenJ9 VM (build HEAD-7ef9591a6f0, JRE 17 Linux ppc64le-64-Bit Compressed References 20220810_61 (JIT enabled, AOT enabled)
 [ERR] OpenJ9   - 7ef9591a6f0
 [ERR] OMR      - 325d6509fe3
 [ERR] JCL      - d5540d6c583 based on jdk-17.0.5+1)

though I don't see how this PR can affect a GC test that executes only java -version

@mpirvu

mpirvu commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

The change in this PR only takes effect when FSD mode is enabled. The cmdLineTester_gcsuballoctests_0 test above does not use FSD mode and thus it cannot be caused by this PR. Hence, I am merging this PR.

@mpirvu
mpirvu merged commit 0dc9054 into eclipse-openj9:master Aug 10, 2022
@mpirvu mpirvu self-assigned this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:jitserver Artifacts related to JIT-as-a-Service project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants