Support the variadic function in FFI downcall - #15778
Merged
tajila merged 1 commit intoSep 21, 2022
Merged
Conversation
Author
|
The fix is to support variadic functions in downcall, which was detected in jtreg tests on JDK17/18/19 There is no change required in JDK18/19+ except a few code in the layout attributes updated in JDK17 at ibmruntimes/openj9-openjdk-jdk17#112. |
ChengJin01
force-pushed
the
support_variadic_args_in_downcall
branch
from
August 25, 2022 15:43
0a44249 to
9a51841
Compare
Author
|
Reviewer: @tajila |
gacholio
reviewed
Aug 25, 2022
gacholio
reviewed
Aug 25, 2022
ChengJin01
force-pushed
the
support_variadic_args_in_downcall
branch
from
August 25, 2022 17:00
9a51841 to
f7bc3ca
Compare
ChengJin01
force-pushed
the
support_variadic_args_in_downcall
branch
from
September 2, 2022 18:50
f7bc3ca to
b9db1b6
Compare
Author
|
@tajila, any comment on this PR? |
tajila
reviewed
Sep 20, 2022
ChengJin01
force-pushed
the
support_variadic_args_in_downcall
branch
from
September 20, 2022 15:34
b9db1b6 to
c2367b1
Compare
tajila
reviewed
Sep 21, 2022
The changes aim to support the variadic function with variadic arguments by setting with ffi_prep_cif_var() in preparing the ffi specific data for downcall. Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
support_variadic_args_in_downcall
branch
from
September 21, 2022 14:52
c2367b1 to
50de744
Compare
Contributor
|
jenkins test sanity win,plinux jdk19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes aim to support the variadic function with
variadic arguments by setting with ffi_prep_cif_var()
in preparing the ffi specific data for downcall.
Signed-off-by: Cheng Jin jincheng@ca.ibm.com