CRIU closes syslog handle before checkpoint unless syslog:none specified - #15793
Merged
Conversation
tajila
reviewed
Aug 30, 2022
tajila
approved these changes
Aug 31, 2022
Contributor
|
Jenkins test sanity win jdk8 |
Contributor
|
Jenkins test sanity xlinuxcriu jdk17 |
Member
Author
|
Looking at the test failure |
Before the checkpoint, use queryLogOptions() to retrieve the system
logger options, if it is not -Xsyslog:none, close the system logger
handle via j9port_control(OMRPORT_CTLDATA_SYSLOG_CLOSE, 0);
After restore, re-open the system logger, and set options with saved
string value;
Added a test to verify that -Xtrace:trigger=tpnid{j9criu.7-8,javadump}
works.
Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
force-pushed
the
closesyslog
branch
from
August 31, 2022 20:30
957ebe3 to
4aeb120
Compare
Member
Author
|
Fixed @tajila this is ready for another run. |
Contributor
|
Jenkins test sanity xlinuxcriu jdk17 |
tajila
approved these changes
Sep 1, 2022
keithc-ca
reviewed
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRIUcloses the system logger handle beforecheckpointunless-Xsyslog:nonespecifiedBefore the
checkpoint, usequeryLogOptions()to retrieve the system logger options, if it is not-Xsyslog:none, close the system logger handle viaj9port_control(OMRPORT_CTLDATA_SYSLOG_CLOSE, 0);After restore, re-open the system logger, and set options with saved string value;
Added a test to verify that
-Xtrace:trigger=tpnid{j9criu.7-8,javadump}works.closes #15776
Signed-off-by: Jason Feng fengj@ca.ibm.com