Skip to content

Add Exception message to Xdump stack agent output - #15854

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
imkabir:8435_feature
Oct 12, 2022
Merged

Add Exception message to Xdump stack agent output#15854
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
imkabir:8435_feature

Conversation

@imkabir

@imkabir imkabir commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

When Xdump:stack is used to dump stack trace filtered on an exception, this change along with the primary exception message, displays additional detail about the exception if any. This is similar to how javacore displays additional detail about an exception in 1TISIGINFO tag.

Fixes: #8435
Signed-off-by: Kabir Islam kaislam1@in.ibm.com

Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
@imkabir

imkabir commented Sep 12, 2022

Copy link
Copy Markdown
Contributor Author

Thank you so much for your review @pshipton. I made the changes. Would appreciate you reviewing the changes. Thank you!

Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
@imkabir

imkabir commented Sep 13, 2022

Copy link
Copy Markdown
Contributor Author

I made the changes. Thank you for your review @pshipton !

Comment thread runtime/rasdump/trigger.c Outdated
@pshipton

Copy link
Copy Markdown
Member

@keithc-ca

Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
@imkabir
imkabir force-pushed the 8435_feature branch 2 times, most recently from b4bd3f7 to 746a11d Compare September 14, 2022 09:16
@imkabir

imkabir commented Sep 14, 2022

Copy link
Copy Markdown
Contributor Author

Thank you so much for your comments @keithc-ca , thank you @pshipton. I have modified the code. Please check if this looks ok to you.

@imkabir
imkabir requested a review from keithc-ca September 14, 2022 09:24
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
@imkabir

imkabir commented Sep 16, 2022

Copy link
Copy Markdown
Contributor Author

Thank you @keithc-ca! Corrected the code.

Comment thread runtime/rasdump/trigger.c Outdated
@imkabir
imkabir force-pushed the 8435_feature branch 2 times, most recently from c46cd36 to e691fa5 Compare September 23, 2022 11:45
@imkabir
imkabir requested a review from keithc-ca September 23, 2022 11:47
@imkabir

imkabir commented Sep 23, 2022

Copy link
Copy Markdown
Contributor Author

@keithc-ca I added this nls message: "J9NLS_DMP_PROCESSING_DETAILED_EVENT_TIME". These are how it looks in different languages:

ca: JVMDUMP055I S'està processant la incidència d'abocament de memòria "throw", detall "java/lang/ClassNotFoundException" "kabir.DontPanic" a 2022/09/22 06:21:05 - espereu.

cs: JVMDUMP055I Probíhá zpracování události výpisu paměti "throw", podrobnosti "java/lang/ClassNotFoundException" "kabir.DontPanic" v 2022/09/22 06:23:00 - čekejte.

de: JVMDUMP055I Speicherauszugsereignis "throw", Detail "java/lang/ClassNotFoundException" "kabir.DontPanic" um 2022/09/22 06:24:43 - bitte warten.

es: JVMDUMP055I Procesando el suceso de volcado "throw", detalles "java/lang/ClassNotFoundException" "kabir.DontPanic" en 2022/09/22 06:26:49 - espere.

fr: JVMDUMP055I Traitement de l'événement de vidage "throw", détails "java/lang/ClassNotFoundException" "kabir.DontPanic" à 2022/09/22 07:06:31 - Veuillez patienter.

hu: JVMDUMP055I "throw" kiíratási esemény feldolgozása, részletek: "java/lang/ClassNotFoundException" "kabir.DontPanic", 2022/09/22 06:31:42 - Kérem várjon.

it: JVMDUMP055I Elaborazione dell'evento dump "throw", dettagli "java/lang/ClassNotFoundException" "kabir.DontPanic" in 2022/09/22 06:32:18 - attendere.

ja: JVMDUMP055I ダンプ・イベント "throw"、詳細 "java/lang/ClassNotFoundException" "kabir.DontPanic" (場所: 2022/09/22 06:33:10) を処理しています - お待ちください。

ko: JVMDUMP055I JVMDUMP055I 덤프 이벤트 "throw" 처리 중, 2022/09/22 07:05:58의 세부사항 "java/lang/ClassNotFoundException" "kabir.DontPanic" - 잠시 기다리십시오.

pl: JVMDUMP055I Przetwarzanie zdarzenia zrzutu "throw", szczegół "java/lang/ClassNotFoundException" "kabir.DontPanic": 2022/09/22 06:35:11 - proszę czekać.

pt_BR: JVMDUMP055I Processando o evento de dump "throw", detalhe "java/lang/ClassNotFoundException" "kabir.DontPanic" em 2022/09/22 06:36:03 - aguarde.

ru: JVMDUMP055I Обработка события дампа "throw", элемент "java/lang/ClassNotFoundException" "kabir.DontPanic" в 2022/09/22 06:36:44. Подождите.

sk: JVMDUMP055I Spracúva sa udalosť výpisu "throw", podrobnosti "java/lang/ClassNotFoundException" "kabir.DontPanic" v 2022/09/22 06:37:25. Čakajte.

sl: JVMDUMP055I Obdelava dogodka izpisa pomnilnika "throw", podrobnost "java/lang/ClassNotFoundException" "kabir.DontPanic" pri 2022/09/22 06:37:59 – prosimo, počakajte.

tr: JVMDUMP055I "throw" döküm olayı (ayrıntı "java/lang/ClassNotFoundException" "kabir.DontPanic") işleniyor - 2022/09/22 06:38:42 - Lütfen bekleyin.

zh_CN: JVMDUMP055I 正在处理转储事件“throw”,详细信息“java/lang/ClassNotFoundException” “kabir.DontPanic”,位于 2022/09/22 06:42:16 - 请稍候。

zh_TW: JVMDUMP055I 正在 2022/09/22 06:42:49 處理傾出事件 "throw",詳細資料 "java/lang/ClassNotFoundException" "kabir.DontPanic" - 請稍候。

Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/nls/dump/j9dmp.nls Outdated
Comment thread runtime/nls/dump/j9dmp.nls Outdated
Comment thread runtime/rasdump/trigger.c Outdated
Comment thread runtime/rasdump/trigger.c Outdated
When Xdump:stack is used to dump stack trace filtered on an exception,
this change along with the primary exception message, displays
additional detail about the exception if any. This is similar to how
javacore displays additional detail about an exception in 1TISIGINFO
tag.

Fixes: eclipse-openj9#8435
Signed-off-by: Kabir Islam <kaislam1@in.ibm.com>
@keithc-ca

Copy link
Copy Markdown
Contributor

jenkins test sanity alinux64 jdk17

@keithc-ca
keithc-ca merged commit 2369840 into eclipse-openj9:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add Exception message to Xdump's "stack" agent output

3 participants