Change method to look for in testFindstackvalue - #15909
Merged
Merged
Conversation
Look for java/lang/Thread.sleep method with only one argument since the form with 2 arguments doesn't show up on the stack in jdk19. Also change MethodForNameOutputParser.extractMethodAddress so we can choose the method instead of taking first matching. Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
pshipton
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look for java/lang/Thread.sleep method with only one argument since the form with 2 arguments doesn't show up on the stack in jdk19.
Also change MethodForNameOutputParser.extractMethodAddress so we can choose the method instead of taking first matching.
Resolves #15850
Tests done against
testDDRExtJunit_FindExtThreadin internal Jenkins server:19: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/27697/
17: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/27708/
11: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/27711/
8: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/27712/