CRIU skips j9sysinfo_get_username/getpwuid to avoid checkpoint failure - #15932
Merged
Conversation
tajila
reviewed
Sep 21, 2022
tajila
reviewed
Sep 22, 2022
When SSSD is enabled, j9sysinfo_get_username/getpwuid can cause checkpoint failure, these methods will be skipped if a checkpoint can be taken, j9sysinfo_get_env is used instead; Added J9PortLibrary.finalRestore which is equivalent to !isCheckpointAllowed(); Removed obsoleted defines ARM_EMULATED, CHORUS & J9PWENT; Refactoring variable initialization, code format around code affected. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
tajila
approved these changes
Sep 23, 2022
Contributor
|
Jenkins test sanity xlinuxcriu jdk17 |
Contributor
|
Jenkins test sanity win jdk8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRIU skips
j9sysinfo_get_username()/getpwuid()to avoid checkpoint failureWhen
SSSDis enabled,j9sysinfo_get_username()/getpwuid()can cause checkpoint failure, these methods will be skipped if a checkpoint can be taken,j9sysinfo_get_env()is used instead;Added
J9PortLibrary.isSafeSSSDMethodwhich is equivalent to!isCheckpointAllowed();Removed obsoleted defines
ARM_EMULATED,CHORUS&J9PWENT;Refactoring variable initialization, code format around code affected.
Internal personal build
Verified manually OpenLiberty checkpoint at
RHEL8w/SSSDenabled.Signed-off-by: Jason Feng fengj@ca.ibm.com