JDK20 deprecates java.lang.Thread.stop() - #15963
Merged
Merged
Conversation
keithc-ca
requested changes
Sep 26, 2022
JasonFengJ9
force-pushed
the
threadconflict
branch
from
September 26, 2022 17:55
2455047 to
4051a2f
Compare
keithc-ca
requested changes
Sep 26, 2022
keithc-ca
left a comment
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
We should also remove JVM_StopThread() for jdk20 (it's no longer used).
Member
Author
It never was used by OpenJ9 Line 2318 in 8cf3092 However, RI hasn't removed it yet [1], OpenJ9 should keep it for now. |
Contributor
|
The reference in the RI is removed in ibmruntimes/openj9-openjdk-jdk#497; see the change to Thread.c. |
keithc-ca
reviewed
Sep 26, 2022
JasonFengJ9
force-pushed
the
threadconflict
branch
from
September 26, 2022 20:57
4051a2f to
9a0e51b
Compare
keithc-ca
reviewed
Sep 27, 2022
Removed j.l.Thread.stopImpl(), JVM_StopThread() and Thread.stopCalled for Java 20+. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
force-pushed
the
threadconflict
branch
from
September 27, 2022 14:52
9a0e51b to
ab81fa8
Compare
keithc-ca
approved these changes
Sep 27, 2022
keithc-ca
left a comment
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
Tested in ibmruntimes/openj9-openjdk-jdk#497.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
j.l.Thread.stopImpl(), andThread.stopCalledfor Java 20+.Depends ibmruntimes/openj9-openjdk-jdk#497
Signed-off-by: Jason Feng fengj@ca.ibm.com