Stack walk loop breaker for ASGCT - #16288
Merged
Merged
Conversation
tajila
reviewed
Nov 9, 2022
Contributor
There was a problem hiding this comment.
Do we need to change DDR for these flags?
Contributor
Author
There was a problem hiding this comment.
No constant has been added or removed, so I assume any use in DDR will pick up the appropriate values from the core. @keithc-ca
tajila
approved these changes
Nov 9, 2022
gacholio
marked this pull request as draft
November 9, 2022 20:10
Contributor
Author
|
Need to refactor to account for JIT inlines, which is currently only done for the cache. |
gacholio
force-pushed
the
loop
branch
2 times, most recently
from
November 9, 2022 20:35
98f3fa2 to
3763f6e
Compare
Prevent potential endless loop in the stack walker when examining the stack of a thread which has been interrupted when not at a safe point. Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
Contributor
Author
|
@tajila Ready for another look. |
Contributor
|
jenkins test sanity amac jdk19 |
Contributor
|
jenkins compile win jdk8 |
Member
|
I'm going to revert this. There are 100s of illegal instruction failures on zlinux and z/OS in an internal build, and this is the only relevant change. |
gacholio
added a commit
to gacholio/openj9
that referenced
this pull request
Nov 11, 2022
Prevent potential endless loop in the stack walker when examining the stack of a thread which has been interrupted when not at a safe point. Same as eclipse-openj9#16288 with J9StackWalkState alignment fixed. Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent potential endless loop in the stack walker when examining the stack of a thread which has been interrupted when not at a safe point.
Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com