Re-write valueType sub-tests - #16299
Merged
Merged
Conversation
1. Re-write testFlatLayoutsWithRecursiveLongs and testACMPTestOnFastSubstitutableValueTypesVer2 using classes from Javac instead of ASM generated classes. 2. Put the new classes in ValueTypeTestClasses, the class names of ValueLong, DoubleLong, QuadLong and DoubleQuadLong now become org/openj9/test/lworld/ValueTypeTestClasses$ValueTypeLong, org/openj9/test/lworld/ValueTypeTestClasses$ValueTypeDoubleLong, org/openj9/test/lworld/ValueTypeTestClasses$ValueTypeQuadLong, org/openj9/test/lworld/ValueTypeTestClasses$ValueTypeDoubleQuadLong. 3. Update the DDR tests to check for the new class names. Closes eclipse-openj9#16291 eclipse-openj9#16292 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
hangshao0
added
comp:test
project:valhalla
hangshao0
force-pushed
the
Test
branch
4 times, most recently
from
November 9, 2022 19:20
26d7c09 to
0eff1ea
Compare
Closes eclipse-openj9#16284 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
Contributor
Author
llxia
reviewed
Nov 9, 2022
hzongaro
reviewed
Nov 9, 2022
hzongaro
left a comment
hzongaro
left a comment
Member
There was a problem hiding this comment.
Looks good. I just wanted to suggest working with Annabelle to get the right set of variations in place for JIT testing.
hzongaro
reviewed
Nov 9, 2022
Comment on lines
+143
to
+146
| <variation>-Xjit:count=0</variation> | ||
| <variation>-Xjit:count=1,disableAsyncCompilation -Xgcpolicy:optthruput</variation> | ||
| <variation>-Xjit:count=1,disableAsyncCompilation -Xgcpolicy:optthruput -XX:ValueTypeFlatteningThreshold=99999</variation> | ||
| <variation>-Xjit:count=1,disableAsyncCompilation -Xgcpolicy:gencon -XX:ValueTypeFlatteningThreshold=99999</variation> |
Member
There was a problem hiding this comment.
Weird! My review comment disappeared.
I just wanted to mention that Annabelle has pull request #16294 pending which adds variations for JIT testing. You might want to coordinate these changes with her to ensure you have the right set of variations.
Contributor
Author
There was a problem hiding this comment.
I will add the new JIT variations if #16294 is merged before this one.
Contributor
hzongaro
approved these changes
Nov 10, 2022
tajila
approved these changes
Nov 10, 2022
Contributor
|
Jenkins test sanity,extended xlinuxval jdknext |
This was referenced Nov 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-write testFlatLayoutsWithRecursiveLongs and
testACMPTestOnFastSubstitutableValueTypesVer2 using classes from Javac
instead of ASM generated classes.
Put the new classes in ValueTypeTestClasses, the class names of
ValueLong, DoubleLong, QuadLong and DoubleQuadLong now become
org/openj9/test/lworld/ValueTypeTestClasses$ValueTypeLong,
org/openj9/test/lworld/ValueTypeTestClasses$ValueTypeDoubleLong,
org/openj9/test/lworld/ValueTypeTestClasses$ValueTypeQuadLong,
org/openj9/test/lworld/ValueTypeTestClasses$ValueTypeDoubleQuadLong.
Update the DDR tests to check for the new class names.
Split ValueTypeArrayTests from ValueTypeTests.
Closes #16291 #16292
Closes #16284
Signed-off-by: Hang Shao hangshao@ca.ibm.com