[FFI/Jtreg] Validate the downcall function address in JDK20 - #17074
Merged
tajila merged 1 commit intoMar 31, 2023
Merged
Conversation
The changes check the life cycle of the surrounding scope of the downcall function address to guarantee the validity of the scope during the downcall. Fixes: eclipse-openj9#17062 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
Author
|
Note: |
Author
ChengJin01
added
comp:vm
project:panama
Contributor
|
jenkins test sanity,openjdk.sanity plinux jdk20 |
Author
It seems the failure was caused by the incorrect setting in the test job at #17074 (comment). |
Contributor
|
jenkins test sanity.openjdk plinux jdk20 |
ChengJin01
pushed a commit
to ChengJin01/openj9
that referenced
this pull request
Jun 5, 2023
The changes rework the previous fix at eclipse-openj9#17074 by performing the scope check before returning the valid downcall address in invokeNative() to avoid any timing issue with the downcall address. Note: The scope check is only intended for JDK20+ as explained at eclipse-openj9#17062. Fixes: eclipse-openj9#17524 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
pushed a commit
to ChengJin01/openj9
that referenced
this pull request
Jun 5, 2023
The changes rework the previous fix at eclipse-openj9#17074 by performing the scope check before returning the valid downcall address in invokeNative() to avoid any timing issue with the downcall address. Note: The scope check is only intended for JDK20+ as explained at eclipse-openj9#17062. Fixes: eclipse-openj9#17524 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
pushed a commit
to ChengJin01/openj9
that referenced
this pull request
Jun 6, 2023
The changes rework the previous fix at eclipse-openj9#17074 by performing the scope check before returning the valid downcall address in invokeNative() to avoid any timing issue with the downcall address. Note: The scope check is only intended for JDK20+ as explained at eclipse-openj9#17062. Fixes: eclipse-openj9#17524 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes check the life cycle of the surrounding scope of the downcall
function address to guarantee the validity of the scope during the downcall.
Fixes: #17062
Signed-off-by: ChengJin01 jincheng@ca.ibm.com