Define J9ClassEnv::primitiveArrayComponentType() - #17274
Merged
vijaysun-omr merged 1 commit intoMay 10, 2023
Merged
Conversation
Contributor
Author
|
@vijaysun-omr, would you mind reviewing? |
vijaysun-omr
approved these changes
May 8, 2023
vijaysun-omr
approved these changes
May 8, 2023
Contributor
|
jenkins test sanity all jdk17 |
Contributor
|
Builds seem to have issue, and I saw the following when I checked linux x86 64 bit |
This (along with a separate change to VP) will allow VP to refine unsafe shadow to a primitive array shadow whenever it can determine that the base object is an instance of a particular primitive array type.
jdmpapin
force-pushed
the
primitive-array-component-type
branch
from
May 9, 2023 15:59
97d980f to
8c025c0
Compare
Contributor
Author
|
Whoops... seems like I was accidentally relying on eclipse-omr/omr#6959 for an Note that although eclipse-omr/omr#6959 has been merged, the changes were reverted in eclipse-omr/omr#6977 due to #17337 |
Contributor
Author
|
Jenkins test sanity all jdk17 |
Contributor
|
jenkins test sanity zlinux jdk17 |
Contributor
|
Checks have passed. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow eclipse-omr/omr#6959 to make VP refine unsafe shadow to a primitive array shadow whenever it can determine that the base object is an instance of a particular primitive array type.
For the purpose of preventing builds from breaking, there should be no dependency between these PRs in either direction. If this one is merged first, then
primitiveArrayComponentType()will simply be unused until eclipse-omr/omr#6959 is merged and promoted. If OTOH eclipse-omr/omr#6959 is merged first, it will use its own default implementation, which simply returnsTR::NoType, leaving the refinement of unsafe shadow to primitive array shadow inactive until this PR is merged as well.