Prototype Continuation caching - #17344
Merged
Merged
Conversation
fengxue-IS
marked this pull request as ready for review
May 9, 2023 22:30
fengxue-IS
added
perf
project:loom
babsingh
requested changes
May 10, 2023
fengxue-IS
force-pushed
the
cacheContinuation
branch
2 times, most recently
from
May 11, 2023 15:46
27966ff to
6ed2e6a
Compare
Contributor
Author
|
Updated comment/format as suggestd. Per discussion, deferring perf optimization to future work. |
- Single per thread local cache to reduce need of alloc/free - Add globalContinuationCacheArray for second tier caching Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
fengxue-IS
force-pushed
the
cacheContinuation
branch
from
May 11, 2023 17:29
6ed2e6a to
23a29a0
Compare
Contributor
|
jenkins test sanity,sanity.openjdk alinux64 jdk20 |
Contributor
|
@tajila Changes LGTM; started the PR builds; let us know if you have any feedback. |
tajila
approved these changes
May 11, 2023
Contributor
|
LGTM |
babsingh
approved these changes
May 11, 2023
keithc-ca
reviewed
May 11, 2023
Contributor
Author
|
No virtual thread related test failure seen in last nightly build, will open a PR to backport this change to 0.39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jack Lu Jack.S.Lu@ibm.com