Skip to content

Update Split List Forced Flag + Revert CRIU Thread Count Reinit - #17459

Merged
amicic merged 1 commit into
eclipse-openj9:masterfrom
RSalman:enable-opt-reinit
Jun 20, 2023
Merged

Update Split List Forced Flag + Revert CRIU Thread Count Reinit#17459
amicic merged 1 commit into
eclipse-openj9:masterfrom
RSalman:enable-opt-reinit

Conversation

@RSalman

@RSalman RSalman commented May 27, 2023

Copy link
Copy Markdown
Contributor
  • Set list split forced flags during cmdline parsing, now required by upstream GC params init API.
  • Revert GC thread count init behaviour: recompute the default thread count when the explicit thread count is invalid.

Signed-off-by: Salman Rana salman.rana@ibm.com

@RSalman

RSalman commented May 27, 2023

Copy link
Copy Markdown
Contributor Author

Depends on eclipse-omr/omr#7009

@RSalman
RSalman force-pushed the enable-opt-reinit branch 3 times, most recently from 78dbb9d to 7fefc89 Compare May 27, 2023 05:30
@RSalman RSalman changed the title Reinit GC Scavenger for Restore (CRIU) Reinit GC Params and Scavenger for Restore (CRIU) May 27, 2023
@RSalman
RSalman force-pushed the enable-opt-reinit branch from 7fefc89 to a364974 Compare May 27, 2023 05:33
@dmitripivkine dmitripivkine added comp:gc criu Used to track CRIU snapshot related work labels May 29, 2023
@RSalman

RSalman commented May 29, 2023

Copy link
Copy Markdown
Contributor Author

@amicic please review

@RSalman
RSalman force-pushed the enable-opt-reinit branch from a364974 to b9b8c04 Compare May 29, 2023 19:28
Comment thread runtime/gc_base/modronapi.cpp Outdated
Comment thread runtime/gc_base/modronapi.cpp Outdated
@RSalman
RSalman force-pushed the enable-opt-reinit branch 2 times, most recently from 88bc6b6 to 4407eaa Compare June 14, 2023 17:54
RSalman added a commit to RSalman/omr that referenced this pull request Jun 14, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
@RSalman RSalman changed the title Reinit GC Params and Scavenger for Restore (CRIU) Reinit GC Params for Restore (CRIU) Jun 14, 2023
Comment thread runtime/gc_modron_startup/mminit.cpp Outdated
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
@RSalman
RSalman force-pushed the enable-opt-reinit branch from 4407eaa to 1a14a9b Compare June 15, 2023 18:47
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Required for downstream OpenJ9 Changes. See
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
@RSalman
RSalman requested a review from amicic June 15, 2023 18:55
@RSalman RSalman changed the title Reinit GC Params for Restore (CRIU) Update Split List Forced Flag + Revert CRIU Thread Count Reinit Behaviour Jun 15, 2023
@RSalman
RSalman force-pushed the enable-opt-reinit branch from 1a14a9b to da535ca Compare June 15, 2023 18:58
@RSalman RSalman changed the title Update Split List Forced Flag + Revert CRIU Thread Count Reinit Behaviour Update Split List Forced Flag + Revert CRIU Thread Count Reinit Jun 15, 2023
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
@RSalman
RSalman force-pushed the enable-opt-reinit branch from da535ca to b9dfbff Compare June 15, 2023 22:58
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
@RSalman
RSalman force-pushed the enable-opt-reinit branch from b9dfbff to dc4373a Compare June 15, 2023 23:33
Comment thread runtime/gc_modron_startup/mminit.cpp Outdated
- Set list split forced flags during cmdline parsing, now required by
upstream GC params init API.
- Revert GC thread count init behaviour: recompute the default thread
count when the explicit thread count is invalid.

Signed-off-by: Salman Rana <salman.rana@ibm.com>
@RSalman
RSalman force-pushed the enable-opt-reinit branch from dc4373a to 9a04bfa Compare June 16, 2023 03:03
@RSalman
RSalman requested a review from amicic June 16, 2023 03:05
@RSalman

RSalman commented Jun 16, 2023

Copy link
Copy Markdown
Contributor Author

Depends on eclipse-omr/omr#7035

RSalman added a commit to RSalman/omr that referenced this pull request Jun 16, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/omr that referenced this pull request Jun 16, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/omr that referenced this pull request Jun 16, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
Comment thread runtime/gc_modron_startup/mmparseXXgc.cpp
@amicic

amicic commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Jenkins test sanity xlinuxcriu jdk17

@amicic

amicic commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

jenkins compile win32,aix jdk8

@amicic
amicic merged commit 963256e into eclipse-openj9:master Jun 20, 2023
jonoommen pushed a commit to jonoommen/omr that referenced this pull request Jun 20, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
jonoommen pushed a commit to jonoommen/omr that referenced this pull request Jun 20, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/openj9-omr that referenced this pull request Jun 22, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/openj9-omr that referenced this pull request Jun 22, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
rmnattas pushed a commit to rmnattas/omr that referenced this pull request Nov 7, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
rmnattas pushed a commit to rmnattas/omr that referenced this pull request Nov 7, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:gc criu Used to track CRIU snapshot related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants