Add missed check for compressed string to jniReleaseStringCritical() - #17641
Conversation
There is missed check for compressed string in MM_VLHGCAccessBarrier::jniReleaseStringCritical() - there is check that compressed strings are enabled. It assumes if strings compression is enabled every single one should be compressed (not true in general). Also added missed check is string compression is enabled to MM_VLHGCAccessBarrier::jniGetStringCritical() Issue eclipse-openj9#17598 Signed-off-by: Dmitri Pivkine <Dmitri_Pivkine@ca.ibm.com>
|
jenkins test sanity win,aix jdk11 |
|
Jenkins compile aix jdk17 |
|
Grinder to verify fix: https://openj9-jenkins.osuosl.org/job/Grinder/2518/ (I hope I set it up correctly). |
Build is green, however I don't see it was using Balanced, so it was not correct. Launching another grinder https://openj9-jenkins.osuosl.org/job/Grinder/2521/ |
|
To verify we need to test with the I also launched a general build with the fix here + string compression enabled over the weekend and it looks clean (the existing failures look clean/reproductions of existing issues): https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-CompactString/16/. |
|
Pls create a PR for 0.40 |
amicic
left a comment
amicic
left a comment
There was a problem hiding this comment.
I missed to formally approve this before merging, but it's was looking good.
4 participants
There is missed check for compressed string in
MM_VLHGCAccessBarrier::jniReleaseStringCritical() - there is check that compressed strings are enabled. It assumes if strings compression is enabled every single one should be compressed (not true in general). Also added missed check is string compression is enabled to MM_VLHGCAccessBarrier::jniGetStringCritical()
Issue #17598