Support HotSpotDiagnosticMXBean in OpenJ9 JDK21+ by babsingh · Pull Request #17709 · eclipse-openj9/openj9

babsingh · 2023-06-29T15:03:47Z

This will allow us to enable a JTReg test for Structured Concurrency.

JTReg test: StructuredTaskScope/StructuredThreadDumpTest

Related: #17634

babsingh · 2023-06-29T15:16:40Z

@pshipton @tajila I verified that StructuredThreadDumpTest passes with this change. Also, I didn't observe any side-effects of this change in personal builds. Can one of you please review these changes?

pshipton · 2023-06-29T15:30:42Z

It seems this will enable other HotSpotDiagnosticMXBean APIs which aren't going to work on OpenJ9. What happens when they are called? We may need to do something so they fail gracefully, such as throw an appropriate exception.

https://download.java.net/java/early_access/jdk21/docs/api/jdk.management/com/sun/management/HotSpotDiagnosticMXBean.html

getDiagnosticOptions()
getVMOption()
setVMOption()

tajila · 2023-06-29T16:02:43Z

Does the use of HotSpotDiagnosticMXBean require -XX:+UnlockDiagnosticVMOptions on hotspot?

babsingh · 2023-06-29T16:10:44Z

It seems this will enable other HotSpotDiagnosticMXBean APIs which aren't going to work on OpenJ9. What happens when they are called? We may need to do something so they fail gracefully, such as throw an appropriate exception.

https://download.java.net/java/early_access/jdk21/docs/api/jdk.management/com/sun/management/HotSpotDiagnosticMXBean.html

getDiagnosticOptions() getVMOption() setVMOption()

Initially, I thought it was only Java code. After running some JTReg tests, these methods also rely upon native methods which are not implemented in OpenJ9. So, I will add an override similar to dumpHeap, which will throw an UnsupportedOperationException.

babsingh · 2023-06-29T16:15:15Z

Does the use of HotSpotDiagnosticMXBean require -XX:+UnlockDiagnosticVMOptions on hotspot?

I don't believe that it requires -XX:+UnlockDiagnosticVMOptions. StructuredThreadDumpTest uses HotSpotDiagnosticMXBean without -XX:+UnlockDiagnosticVMOptions.

babsingh · 2023-06-29T17:32:32Z

All feedback comments have been addressed.

babsingh · 2023-06-29T21:18:29Z

Previous feedback has been addressed: removed the module check and added error handling as per the Javadoc.

pshipton · 2023-06-29T21:28:06Z

What test suite(s) did you run already?

babsingh · 2023-06-29T21:48:49Z

What test suite(s) did you run already?

JDK21: sanity.functional,sanity.openjdk,extended.openjdk. JDK21 personal build: https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/17143/

JDK17: sanity.functional. JDK17 personal build: https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/17144/

Ran the disabled test locally.

Also, accounted for the recent feedback: an empty list is returned and exception messages have been updated.

pshipton · 2023-06-30T01:59:53Z

jenkins test extended amac jdk11,jdk21

This will allow us to enable a JTReg test for Structured Concurrency. JTReg test: StructuredTaskScope/StructuredThreadDumpTest Related: eclipse-openj9#17634 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

babsingh · 2023-06-30T13:58:15Z

Old PR builds: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/4025/. No issues seen during local testing with the latest changes.

keithc-ca · 2023-06-30T14:57:25Z

-			create(OPENJ9_DIAGNOSTICS_MXBEAN_NAME, openj9.lang.management.internal.OpenJ9DiagnosticsMXBeanImpl.getInstance())
-				.addInterface(openj9.lang.management.OpenJ9DiagnosticsMXBean.class)
-				.validateAndRegister();


Please help me understand why this was removed. This code is specific to Java 8 where there's no possibility that OpenJ9DiagnosticsMXBeanImpl.getInstance() might return null (even though the code would properly handle that situation). Why do we no longer want this bean to be registered?

Ah good catch, I missed it was specific to 8 (and we didn't test 8). So we need to add it back and add the HotspotBean there too.

Opened #17726 to readd the registration calls.

The registration call was removed in eclipse-openj9#17709 due to a false assumption. It has been added back since it is still required. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

eclipse-openj9/openj9#17709 adds the required support to enable StructuredThreadDumpTest. Related issues which can be closed after the test is enabled: - eclipse-openj9/openj9#17634 - eclipse-openj9/openj9#15278 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

pshipton added the comp:vm label Jun 29, 2023

pshipton reviewed Jun 29, 2023

View reviewed changes

Comment thread ...src/java.management/share/classes/com/ibm/java/lang/management/internal/ManagementUtils.java Outdated

babsingh force-pushed the support_HotSpotDiagnosticMXBean branch 2 times, most recently from 4dd830d to 46460ea Compare June 29, 2023 17:21

pshipton reviewed Jun 29, 2023

View reviewed changes

babsingh force-pushed the support_HotSpotDiagnosticMXBean branch from 46460ea to 3c5d345 Compare June 29, 2023 21:08

pshipton reviewed Jun 29, 2023

View reviewed changes

Comment thread jcl/src/jdk.management/share/classes/com/sun/management/internal/ExtendedHotSpotDiagnostic.java Outdated

pshipton reviewed Jun 29, 2023

View reviewed changes

Comment thread jcl/src/jdk.management/share/classes/com/sun/management/internal/ExtendedHotSpotDiagnostic.java Outdated

babsingh force-pushed the support_HotSpotDiagnosticMXBean branch from 3c5d345 to 5daea5b Compare June 29, 2023 21:44

pshipton reviewed Jun 30, 2023

View reviewed changes

Comment thread jcl/src/jdk.management/share/classes/com/sun/management/internal/ExtendedHotSpotDiagnostic.java Outdated

Support HotSpotDiagnosticMXBean in OpenJ9 JDK21+

346a572

This will allow us to enable a JTReg test for Structured Concurrency. JTReg test: StructuredTaskScope/StructuredThreadDumpTest Related: eclipse-openj9#17634 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

babsingh force-pushed the support_HotSpotDiagnosticMXBean branch from 5daea5b to 346a572 Compare June 30, 2023 13:54

pshipton approved these changes Jun 30, 2023

View reviewed changes

pshipton merged commit 2ea9da2 into eclipse-openj9:master Jun 30, 2023

keithc-ca reviewed Jun 30, 2023

View reviewed changes

babsingh mentioned this pull request Jun 30, 2023

Restore OpenJ9DiagnosticsMXBean registration call in ManagementUtils #17726

Merged

babsingh mentioned this pull request Jul 6, 2023

[JDK21] Enable StructuredThreadDumpTest for OpenJ9 adoptium/aqa-tests#4659

Merged

This was referenced Jul 6, 2023

jdk21 java/util/concurrent/StructuredTaskScope/StructuredThreadDumpTest cannot find symbol HotSpotDiagnosticMXBean #17634

Closed

JDK19 jdk_other_0_FAILED error: cannot find symbol HotSpotDiagnosticMXBean.ThreadDumpFormat #15278

Closed

babsingh mentioned this pull request Jul 31, 2023

JEP 453: Structured Concurrency (Preview) #17487

Closed

babsingh mentioned this pull request Aug 18, 2025

JDK25 StructuredTaskScope/StructuredThreadDumpTest JVM_CreateThreadSnapshot unimplemented #22220

Closed

Uh oh!

Conversation

babsingh commented Jun 29, 2023

Uh oh!

babsingh commented Jun 29, 2023

Uh oh!

pshipton commented Jun 29, 2023

Uh oh!

Uh oh!

tajila commented Jun 29, 2023

Uh oh!

babsingh commented Jun 29, 2023

Uh oh!

babsingh commented Jun 29, 2023

Uh oh!

babsingh commented Jun 29, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

babsingh commented Jun 29, 2023

Uh oh!

pshipton commented Jun 29, 2023

Uh oh!

Uh oh!

Uh oh!

babsingh commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pshipton commented Jun 30, 2023

Uh oh!

Uh oh!

babsingh commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keithc-ca Jun 30, 2023

Choose a reason for hiding this comment

Uh oh!

pshipton Jun 30, 2023

Choose a reason for hiding this comment

Uh oh!

babsingh Jun 30, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

babsingh commented Jun 29, 2023 •

edited

Loading

babsingh commented Jun 30, 2023 •

edited

Loading