Skip to content

Update source build version for Valhalla to JDK22 - #17760

Merged
hangshao0 merged 1 commit into
eclipse-openj9:masterfrom
a7ehuo:fix-valhalla-build-jdk21
Jul 10, 2023
Merged

Update source build version for Valhalla to JDK22#17760
hangshao0 merged 1 commit into
eclipse-openj9:masterfrom
a7ehuo:fix-valhalla-build-jdk21

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Jul 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update source build version for Valhalla to JDK22

@a7ehuo
a7ehuo requested a review from hangshao0 July 10, 2023 14:50
@a7ehuo a7ehuo added the project:valhalla Used to track Project Valhalla related work label Jul 10, 2023
@a7ehuo

a7ehuo commented Jul 10, 2023

Copy link
Copy Markdown
Contributor Author

This PR should resolve the nightly Valhalla test build failure with openj9-openjdk-jdk.valuetypes.

22:06:02      [javac] /home/jenkins/workspace/Test_openjdkValhalla_j9_sanity.functional_x86-64_linux_valhalla_Nightly_testList_0/aqa-tests/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeArrayTests.java:45: error: value classes are not supported in -source 20
22:06:02      [javac] 	static value class PointV implements SomeIface {
22:06:02      [javac] 	       ^
22:06:02      [javac]   (use -source 21 or higher to enable value classes)
22:06:02      [javac] /home/jenkins/workspace/Test_openjdkValhalla_j9_sanity.functional_x86-64_linux_valhalla_Nightly_testList_0/aqa-tests/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeArrayTests.java:58: error: primitive classes are not supported
22:06:02      [javac] 	static primitive class PointPV implements SomeIface {

@a7ehuo a7ehuo changed the title Change source build version for Valhalla to JDK21 Update source build version for Valhalla to JDK21 Jul 10, 2023
@a7ehuo
a7ehuo force-pushed the fix-valhalla-build-jdk21 branch from 8fe9902 to 619677c Compare July 10, 2023 14:52
@a7ehuo

a7ehuo commented Jul 10, 2023

Copy link
Copy Markdown
Contributor Author

@hangshao0 May I ask you to review this change? Thank you!

@hzongaro fyi

@hangshao0

hangshao0 commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Jenkins test sanity,extended xlinuxval jdknext

hangshao0
hangshao0 reviewed Jul 10, 2023
View reviewed changes
Comment thread test/functional/Valhalla/build.xml Outdated
Annabelle Huo Annabelle Huo
Update source build version for Valhalla to JDK22
c2a259d 
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo force-pushed the fix-valhalla-build-jdk21 branch from 619677c to c2a259d Compare July 10, 2023 17:31
@a7ehuo a7ehuo changed the title Update source build version for Valhalla to JDK21 Update source build version for Valhalla to JDK22 Jul 10, 2023
@hangshao0

hangshao0 commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Jenkins test sanity,extended xlinuxval jdknext

hangshao0
hangshao0 approved these changes Jul 10, 2023
View reviewed changes

@hangshao0 hangshao0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@hangshao0
hangshao0 merged commit a411eb6 into eclipse-openj9:master Jul 10, 2023
@a7ehuo
a7ehuo deleted the fix-valhalla-build-jdk21 branch March 6, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hangshao0 hangshao0 hangshao0 approved these changes

Assignees

No one assigned

Labels

comp:test project:valhalla Used to track Project Valhalla related work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a7ehuo @hangshao0