Rename TR_InlinedSiteHastTableEntry to TR_InlinedSiteHashTableEntry. - #17848
Conversation
|
Jenkins test sanity all jdk17 |
|
@prajwalbandak, while testing of this commit is on-going, may I ask you to modify your commit message to include a body section that provides at least some of the justification for the change that you've included in the pull request description above, as is described in the Contributor Guidelines? I was going to let it go in this case, as the change is relatively straightforward, but I reconsidered and think it's worthwhile to have that little extra bit of detail. |
|
hey @hzongaro, modified the commit message. and Look like a Build failure, Can you please explain what is the next step I can do? |
|
@prajwalbandak, it looks like your commit still has the original message. If you're using the git command-line client, you might need run the following command to update the commit in this pull request. I'm looking at the failures. I don't think they're related to your change. |
|
Hey @hzongaro , One doubt once again I need make pull request? |
Hi, @prajwalbandak. No, you should be able to "force push" without creating a new pull request. That should update your existing pull request. |
|
@hzongaro , Done. When I executed 'git push --force', the output showed 'everything up to date', and the modified code is now present in the GitHub repository. As a first-time contributor, I'm finding the process a bit challenging. Can you please explain what to do next? |
|
Sorry, @prajwalbandak. It looks like something went wrong with your attempt to revise your commit message and push the new version; the pull request still contains the original version of the commit with its original commit message, and it also now contains more recent changes that are unrelated to this pull request. If you reach out to me in the OpenJ9 Slack workspace https://openj9.slack.com/, I can try to help you work through these issues. |
|
@hzongaro Can you please share the invitation link for Slack? |
|
Here is the shared invitation link for the Slack workspace: |
The identifier "TR_InlinedSiteHashTableEntry" was mistakenly misspelled as "TR_InlinedSiteHastTableEntry" in various parts of codebase. This typographical error caused confusion and inconsistencies throughout the project. This commit addresses the issue by correcting the typo and renaming the variable to "TR_InlinedSiteHashTableEntry" consistently throughout the project.
|
Jenkins test sanity all jdk17 |
|
Jenkins test sanity aix,win jdk17 |
|
The failing tests appear to be infrastructure related. As this looks like a very safe change, and testing passed on most platforms, I will go ahead and merge it. |
2 participants
Fix typo in variable identifier "TR_InlinedSiteHastTableEntry"
The identifier "TR_InlinedSiteHastTableEntry" was mistakenly misspelled as "TR_InlinedSiteHashTableEntry" in various parts of the codebase. This typographical error caused confusion and inconsistencies throughout the project.
This commit addresses the issue by correcting the typo and renaming the variable to "TR_InlinedSiteHashTableEntry" consistently throughout the project.
By using the correct identifier, we improve code readability and maintain consistency, reducing the potential for future errors and misunderstandings in the codebase.
Closes: #17450
Signed-off-by: prajwalbandak prajwalbandak777@gmail.com