Skip to content

AArch64: Use front end query when allocating VI Thunks - #17904

Merged
knn-k merged 1 commit into
eclipse-openj9:masterfrom
Akira1Saitoh:aarch64VIThunk
Aug 4, 2023
Merged

AArch64: Use front end query when allocating VI Thunks#17904
knn-k merged 1 commit into
eclipse-openj9:masterfrom
Akira1Saitoh:aarch64VIThunk

Conversation

@Akira1Saitoh

Copy link
Copy Markdown
Contributor

This commit updates TR::ARM64CallSnippet::generateVIThunk to use front end query to determine the type of memory where VI thunk instructions are stored.

This commit updates `TR::ARM64CallSnippet::generateVIThunk` to
use front end query to determine the type of memory where
VI thunk instructions are stored.

Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
@knn-k

knn-k commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

Jenkins test sanity alinux64,amac jdk17

@knn-k

knn-k commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

p uses compileRelocatableCode() while z uses storeOffsetToArgumentsInVirtualIndirectThunks() in generateVIThunk(). The z code was changed by PR #6910:

if (comp->compileRelocatableCode())
thunk = (uint8_t *)comp->trMemory()->allocateMemory(codeSize, heapAlloc);
else
thunk = (uint8_t *)cg->allocateCodeMemory(codeSize, true, false);

if (fej9->storeOffsetToArgumentsInVirtualIndirectThunks())
thunk = (uint8_t *)comp->trMemory()->allocateMemory(codeSize, heapAlloc);
else
thunk = (uint8_t *)cg->allocateCodeMemory(codeSize, true);

@knn-k knn-k self-assigned this Aug 4, 2023
@knn-k
knn-k merged commit e99a175 into eclipse-openj9:master Aug 4, 2023
@knn-k knn-k mentioned this pull request Aug 3, 2023
12 tasks
@Akira1Saitoh
Akira1Saitoh deleted the aarch64VIThunk branch August 17, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants