isCompilable() fix for JITServer - #17943
Merged
Merged
Conversation
mpirvu
reviewed
Aug 14, 2023
mpirvu
left a comment
mpirvu
left a comment
Contributor
There was a problem hiding this comment.
Code should be deleted rather than commented out
Contributor
|
I think that the commit message should indicate that the deleted code is redundant since the base class TR_ResolvedJ9Method already filters those methods out |
mpirvu
reviewed
Aug 14, 2023
mpirvu
left a comment
mpirvu
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please squash the two commits
TR_ResolvedJ9Method::isCompilable() accesses some fields from JavaVM and it's not safe to use as is in out-of-process compilations. As described in the issue eclipse-openj9#17931, the deleted "doPrivileged" code is redundant since the base class method TR_ResolvedJ9MethodBase::isCompilable() already filters those methods out. Closes: #eclipse-openj9#17931 Signed-off-by: Sajina Kandy <sajina.kandy@ibm.com>
SajinaKandy
force-pushed
the
isCompilable
branch
from
August 14, 2023 23:35
c6dafde to
c340c9f
Compare
Contributor
|
jenkins test sanity all jdk21 |
Contributor
Author
|
Test results for |
Contributor
|
Build on AIX failed due to infra: |
Contributor
|
jenkins test sanity aix jdk21 |
mpirvu
marked this pull request as ready for review
August 18, 2023 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned in 17931.TR_ResolvedJ9Method::isCompilable() accesses some fields from JavaVM and it's not safe to use as is in out-of-process compilations.
As described in the issue #17931, the deleted "doPrivileged" code is redundant since the base class method TR_ResolvedJ9MethodBase::isCompilable() already filters those methods out.
Closes: ##17931