Check NullRestricted attribute - #18179
Merged
hzongaro merged 1 commit intoSep 26, 2023
Merged
Conversation
3 tasks
a7ehuo
force-pushed
the
check-isFieldNullRestricted-PR
branch
from
September 21, 2023 17:29
2a13600 to
8cb6cb5
Compare
Contributor
Author
|
@hzongaro May I ask you to review this change? Thanks! |
theresa-m
approved these changes
Sep 22, 2023
theresa-m
left a comment
theresa-m
left a comment
Contributor
There was a problem hiding this comment.
I have reviewed the test code.
hzongaro
reviewed
Sep 22, 2023
hzongaro
left a comment
hzongaro
left a comment
Member
There was a problem hiding this comment.
Thanks, Annabelle! Just a few comments.
a7ehuo
force-pushed
the
check-isFieldNullRestricted-PR
branch
from
September 22, 2023 22:41
8cb6cb5 to
32f6437
Compare
Contributor
Author
|
@hzongaro @theresa-m All comments are addressed. Ready for another review. Thanks! |
hzongaro
reviewed
Sep 23, 2023
hzongaro
left a comment
hzongaro
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates. It looks like there are still a few more cases where _methodSymbol->isStatic() was being used in the old code where it shouldn't have been.
`NullRestricted` field attribute is introduced in JEP 401. - Create API to check `NullRestricted` - Replace calls to `isFieldQType` with `isFieldNullRestricted` - Remove `isClassRefPrimitiveValueType` - Update the test to test JIT'd methods Related: eclipse-openj9#18170 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
check-isFieldNullRestricted-PR
branch
from
September 25, 2023 15:03
32f6437 to
0405834
Compare
Contributor
Author
Member
|
Jenkins test sanity xlinuxval,xlinuxvalst jdknext |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NullRestrictedfield attribute is introduced in JEP 401.NullRestrictedisFieldQTypewithisFieldNullRestrictedisClassRefPrimitiveValueTypeRelated: #18170