Disable latest JDK22 APIs for Valhalla - #18327
Merged
Merged
Conversation
JasonFengJ9
added
comp:vm
project:valhalla
keithc-ca
requested changes
Oct 23, 2023
Valhalla doesn't support latest JDK22 APIs: JavaLangAccess.ensureNativeAccess(Module mod, Class<?> clsOwner, String methodName, Class<?> clsCaller); JavaLangAccess.bytesCompatible(String string, Charset charset); JavaLangAccess.copyToSegmentRaw(String string, MemorySegment segment, long offset); LinkerOptions.isCritical(). Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
force-pushed
the
fixvalhalla
branch
from
October 23, 2023 14:06
cdaf039 to
e863c51
Compare
keithc-ca
approved these changes
Oct 23, 2023
Contributor
|
jenkins compile winval jdknext |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable latest
JDK22APIs forValhallaValhalla doesn't support the latest JDK22 APIs:
JavaLangAccess.ensureNativeAccess(Module mod, Class<?> clsOwner, String methodName, Class<?> clsCaller);JavaLangAccess.bytesCompatible(String string, Charset charset);JavaLangAccess.copyToSegmentRaw(String string, MemorySegment segment, long offset);LinkerOptions.isCritical().FYI @hangshao0
Signed-off-by: Jason Feng fengj@ca.ibm.com