Skip to content

Fix JNI Local Reference reporting issue - #18379

Merged
amicic merged 1 commit into
eclipse-openj9:masterfrom
LinHu2016:Loom_GC_update_21
Nov 1, 2023
Merged

Fix JNI Local Reference reporting issue#18379
amicic merged 1 commit into
eclipse-openj9:masterfrom
LinHu2016:Loom_GC_update_21

Conversation

@LinHu2016

Copy link
Copy Markdown
Contributor

JNI Local References could be found on the stack(first 8 of them) or from GC_VMThreadJNISlotIterator (vmThread->jniLocalReferences). need to update MM_ReferenceChainWalker::doVMThreadSlot() to report J9GC_ROOT_TYPE_JNI_LOCAL type for the case walkState->slotType = J9_STACKWALK_SLOT_TYPE_JNI_LOCAL.

relate: #18378 and #17712
Signed-off-by: hulin linhu@ca.ibm.com

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double ;;

@amicic

amicic commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

jenkins test sanity win,aix jdk21

JNI Local References could be found on the stack(first 8 of them) or
from GC_VMThreadJNISlotIterator (vmThread->jniLocalReferences).
need to update MM_ReferenceChainWalker::doVMThreadSlot() to report
J9GC_ROOT_TYPE_JNI_LOCAL type for the case  walkState->slotType =
J9_STACKWALK_SLOT_TYPE_JNI_LOCAL.

Signed-off-by: hulin <linhu@ca.ibm.com>
@amicic

amicic commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

changes rebased, so here is the link to jenkins builds

https://openj9-jenkins.osuosl.org/view/Pull%20Requests/job/PullRequest-OpenJ9/4655/

@amicic

amicic commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

one AIX subtest failed, but seems unrelated:

Testing: -XX:-HandleSIGABRT -XX:+HandleSIGABRT
Test start time: 2023/10/31 19:21:22 Coordinated Universal Time
Running command: "/home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_ppc64_aix_Personal_testList_1/openjdkbinary/j2sdk-image/bin/java"   -Xmx20m -Xdump:system+heap+snap+jit:none -XX:-HandleSIGABRT -XX:+HandleSIGABRT -cp "/home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_ppc64_aix_Personal_testList_1/aqa-tests/TKG/../../jvmtest/functional/cmdline_options_testresources/cmdlinetestresources.jar" VMBench.GPTests.GPTest abort
Time spent starting: 6 milliseconds
Time spent executing: 239 milliseconds
Test result: FAILED
Output from test:
 [OUT] Invoking abort!
 [ERR] JVMDUMP039I Processing dump event "abort", detail "" at 2023/10/31 19:21:22 - please wait.
 [ERR] JVMDUMP032I JVM requested Java dump using '/home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_ppc64_aix_Personal_testList_1/aqa-tests/TKG/output_1698774789184/cmdLineTest_sigabrtHandlingTest_0/javacore.20231031.192122.51708104.0001.txt' in response to an event
 [ERR] 
 [ERR] 
 [ERR] *** Invalid JIT return address 0A00010009608E27 in 0000010010094630
 [ERR] 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants